From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C81331EB6; Thu, 2 Jul 2026 16:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009820; cv=none; b=qqWr1TFODoDAct42kdSv0RmqLq7UUlTnRA+5SOqnC6fCAjws4YifwotS35B18eeIr4DVAdF8t4w+pcscZDo7PK1LO8Nn5Nj+XsUWtfzdxkPgS/k5mFpqnppQCpKZ7bSvkPMQ++ImAlcAitXKgRF80GNb4wKEUC+pKWc4ZaiuOlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009820; c=relaxed/simple; bh=SE0gYs9eO9pw2H2tuUq8g/neVbtEoRdODJ0du2sfcPE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sya6hEi/m/06OiylD/5gVTqcsxGsgnme3NKLqELBo8ZfrAA9cmKo1tv5tRiomGaiOHTO1hOxRg6QX4z8Waz10AOtLGHYlvUq4EgjJ7FbjSJfGdYr1WksuSR7r+kg9S1bvRGdkm7FYoy0O6l/ySzfd4r2rMP2vfmoZl+MIiwFXOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tbXoa4DO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tbXoa4DO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 693CD1F00A3A; Thu, 2 Jul 2026 16:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783009817; bh=IpmTZbJ62SvifJ9ZGFUbJ2UQUyDdmqtL36nHvaeKrSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tbXoa4DO+6gbGPIuqcH2+oLYo+6Q2eSxvdsY1p7X5D2jbYrjcMYQEzpJ8uJpTrveC Gd2HNXN3oF1HFUeub5jSYevksGbYgi2hJXJeP0uKEhXRM9hBGNz5/EuN8LSNSAWCCq He0d98OhuoB5rNwNl/26ubayRWaC2Tizd/lIE2j0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thorsten Blum , Herbert Xu , Sasha Levin Subject: [PATCH 5.15 92/95] crypto: qat - Replace kzalloc() + copy_from_user() with memdup_user() Date: Thu, 2 Jul 2026 18:20:35 +0200 Message-ID: <20260702155111.145414410@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702155109.196223802@linuxfoundation.org> References: <20260702155109.196223802@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thorsten Blum [ Upstream commit 1e26339703e2afd397037defa798682b2b93dcc0 ] Replace kzalloc() followed by copy_from_user() with memdup_user() to improve and simplify adf_ctl_alloc_resources(). memdup_user() returns either -ENOMEM or -EFAULT (instead of -EIO) if an error occurs. Remove the unnecessary device id initialization, since memdup_user() (like copy_from_user()) immediately overwrites it. No functional changes intended other than returning the more idiomatic error code -EFAULT. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu Stable-dep-of: d237230728c5 ("crypto: qat - remove unused character device and IOCTLs") Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/qat/qat_common/adf_ctl_drv.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) --- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c +++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c @@ -87,17 +87,10 @@ static int adf_ctl_alloc_resources(struc { struct adf_user_cfg_ctl_data *cfg_data; - cfg_data = kzalloc(sizeof(*cfg_data), GFP_KERNEL); - if (!cfg_data) - return -ENOMEM; - - /* Initialize device id to NO DEVICE as 0 is a valid device id */ - cfg_data->device_id = ADF_CFG_NO_DEVICE; - - if (copy_from_user(cfg_data, (void __user *)arg, sizeof(*cfg_data))) { + cfg_data = memdup_user((void __user *)arg, sizeof(*cfg_data)); + if (IS_ERR(cfg_data)) { pr_err("QAT: failed to copy from user cfg_data.\n"); - kfree(cfg_data); - return -EIO; + return PTR_ERR(cfg_data); } *ctl_data = cfg_data;