From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D9C922D7B9; Thu, 2 Jul 2026 16:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011518; cv=none; b=V8MN87qqg6dFGAmSbw2xTvh+ekJ/3iWnFB1eBMRAnjTuBZ/Y909GXhfIyvSpflHSANBjZqEQ0QPVTMagnjSUOl1C0cgmQZCr8uWEz3ZgB+jpW/d44I6PZzAl7eQsS+KTyAbkBT1w+VNoAyC4CZX+hNPXpQomakixpZvXlndf8TI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011518; c=relaxed/simple; bh=niIuzV3HU2oZJxiEVh5mt410yICNuBtUS45bDOX/GaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YXujdryVAnep0nKnJFtotIrhezfBzcro+0pGEnM5gEMhEb5CjGbBAPcXDU64gpYC0yJ35VM1hUYp88JqRQnICpPuVUmrekCzzqLOPRPMCAPZY6gBtJ1YZZ283Anjt2zTygXhH/tEaIj21K9RRSjU/Z5UiIKvZQ5g4EhZYR66iBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QsDn4COf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QsDn4COf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00BBE1F00A3A; Thu, 2 Jul 2026 16:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783011517; bh=JHsT+mG9FCSkfEGw3kqYdBybbEU/xZhJydH8MNOY1Qo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QsDn4COfMDzwlJr3HxqMWHaCeIduLywA/9Tf5UeDQYHZ0yGOo0y0nnld0BEGFJMCI N5B4q70/hPOr+GszS21FrepEVUdpVEOzsqQklSSRB8OKpqqzvtsvaKNMaoVG9aFfJ3 1Qpst20spDnfvEe4k2WeXQXR0/wPTrOo4io66B9g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Sven Eckelmann , Sasha Levin Subject: [PATCH 7.1 003/120] batman-adv: tp_meter: initialize dup_acks explicitly Date: Thu, 2 Jul 2026 18:19:59 +0200 Message-ID: <20260702155113.036387580@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702155112.964534952@linuxfoundation.org> References: <20260702155112.964534952@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sven Eckelmann commit b2b68b32a715e0328662801576974aa37b942b00 upstream. When an ack with a sequence number equal to the last_acked is received, the dup_acks counter is increased to decide whether fast retransmit should be performed. Only when the sequence numbers are not equal, the dup_acks is set to the initial value (0). But if the initial packet would have the sequence number BATADV_TP_FIRST_SEQ, dup_acks would not be initialized and atomic_inc would operate on an undefined starting value. It is therefore required to have it explicitly initialized during the start of the sender session. Cc: stable@kernel.org Fixes: 33a3bb4a3345 ("batman-adv: throughput meter implementation") Signed-off-by: Sven Eckelmann Signed-off-by: Sasha Levin --- net/batman-adv/tp_meter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c index e8941f753a9697..0325b951ff8a8e 100644 --- a/net/batman-adv/tp_meter.c +++ b/net/batman-adv/tp_meter.c @@ -1045,6 +1045,7 @@ void batadv_tp_start(struct batadv_priv *bat_priv, const u8 *dst, tp_vars->icmp_uid = icmp_uid; tp_vars->last_sent = BATADV_TP_FIRST_SEQ; + atomic_set(&tp_vars->dup_acks, 0); atomic_set(&tp_vars->last_acked, BATADV_TP_FIRST_SEQ); tp_vars->fast_recovery = false; tp_vars->recover = BATADV_TP_FIRST_SEQ; -- 2.53.0