From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A6B8318ED2; Thu, 2 Jul 2026 16:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011421; cv=none; b=t92yzC12plQVzoKnEdL+nPT/EAyOEZtOYK7ks5D/I4hoF/YoT8qPcXOt0Dv6il+97i/34zaZmTtQucTfvVnsEUdh4q62XgT5QmBScVJzUCQ6YLf7+VzJxEEKsuV02BN0aeb8YRTgInBWfm4bBTOzirKNbA1QFQfC2JNtStRcLeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011421; c=relaxed/simple; bh=V6w7LLlLoSGjL/vOwvVyjlTtSc9LwG2eW2tWrnJChIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qlLTbXdmOHTB8bcNE0s9mpcpXhlt4awkv2j2Lpj27zDU0MZqadGK/FfEHU5/lnse65y2vjZPH+D8VdRdQD1wTd94jN+E+rYfgUvdr273vmZTMo2msyyBDfbUEM5LggZId/S2l0fG+EnU/QqiFnfZOM3LAGzL0qTUn/zVi4i671U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Y88TWfrv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y88TWfrv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FFF51F00A3A; Thu, 2 Jul 2026 16:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783011420; bh=MuPRszwcqrkL0QZtTld+Qq8QKQCNOGzdKg9dTmW41P8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Y88TWfrvRaFjhN9hORLeg0xIa2e6inuw9klweIkCZ7N2z5NGXet9uJGZEy8ZyvIJ2 cVxjMMD5u27zNsy11fYf+L3wv9pvFxHX9kg9YuXnHbh82QyMooYjkPkP0U1L9HYJHs oAS8qLKRj3lfFge9wa2rffTb/cy5Wq/SOlfqrJTs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guannan Wang , Chuck Lever Subject: [PATCH 6.18 095/108] NFSD: Fix SECINFO_NO_NAME decode error cleanup Date: Thu, 2 Jul 2026 18:21:32 +0200 Message-ID: <20260702155114.080501861@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702155112.110058792@linuxfoundation.org> References: <20260702155112.110058792@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guannan Wang commit 9e18e83b8846a5c3fe13fc8a464b4865d33996c6 upstream. nfsd4_decode_secinfo_no_name() currently initializes sin_exp after decoding sin_style. If the XDR stream is truncated, the decoder returns nfserr_bad_xdr before sin_exp is initialized. Since commit 3fdc54646234 ("NFSD: Reduce amount of struct nfsd4_compoundargs that needs clearing"), the inline iops array is not cleared between RPC calls. A failed SECINFO_NO_NAME decode can therefore leave sin_exp holding stale union contents from a previous operation. The error response path still invokes nfsd4_secinfo_no_name_release(), which calls exp_put() on a non-NULL sin_exp. Initialize sin_exp before the first failable decode step, matching nfsd4_decode_secinfo(). Fixes: 3fdc54646234 ("NFSD: Reduce amount of struct nfsd4_compoundargs that needs clearing") Cc: stable@vger.kernel.org Signed-off-by: Guannan Wang Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfs4xdr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -1871,10 +1871,11 @@ static __be32 nfsd4_decode_secinfo_no_na union nfsd4_op_u *u) { struct nfsd4_secinfo_no_name *sin = &u->secinfo_no_name; + + sin->sin_exp = NULL; if (xdr_stream_decode_u32(argp->xdr, &sin->sin_style) < 0) return nfserr_bad_xdr; - sin->sin_exp = NULL; return nfs_ok; }