From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4C9F1FA859; Thu, 2 Jul 2026 17:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011736; cv=none; b=aOJCerKTfXHrWvvVbTrVdhoj5T2PQcJjeJYh6Rr3ifmbA3VZYjqZiOGxsTYBujcuL24awodE/4/T6NtLDexgwLSXtlhykQZ/3LjCkWAcEsW3LQ/bEqd5qswo/U6mrWT+v4QkFzEJ9jA8iAadWrf5WSLhvIcQGDHQuzxAGHREw4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011736; c=relaxed/simple; bh=/DJS2PeKux1TzP/Mv3hcvCuDnpbKnnP8IoavdUUBq6k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sOBatPsryQeGfqaRpz5RDbLc1OrZ7W6fmo8BuyFshDS+TA4TYC6KbGPDmnpke4q67KbEj0ZxOjMTGusMpjXq1afzv+PO6JKicWIygsQfyrj2EM7g9m0ohfFsfhFTTxnD6XkwNP+KnvYmb5AZAk1UU2hXkAB0jEMRmCUtXJ4eams= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jWdFbR2r; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jWdFbR2r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E82521F000E9; Thu, 2 Jul 2026 17:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783011735; bh=DjinC9YyAIYUB1+hxxcIuIgmzy3afT9yAXCHgiSyyyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jWdFbR2rwrKyOeLYkSjLmlZ96svTivU2tkZYWYlzahP2+K0dHo2R67IkwS9vpett0 /KVaIivhuYLUojDaSVpk2x+3nxSi0adNMDh7K7ey6iG6CLzehlaf1mRhuO1b9zkQ41 hG1ob4WtqXviWNi8LCYBRDg3jczygu/SDiwBjdn0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Sebastian Reichel Subject: [PATCH 7.1 096/120] power: reset: linkstation-poweroff: fix use-after-free in the linkstation_poweroff_init() Date: Thu, 2 Jul 2026 18:21:32 +0200 Message-ID: <20260702155114.945011006@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702155112.964534952@linuxfoundation.org> References: <20260702155112.964534952@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang commit 8eec545cde69e46e9a1d2b7d915ce4f5df85b3bd upstream. Move of_node_put(dn) after the of_match_node() call, which still needs the node pointer. The node reference is correctly released after use. Fixes: e2f471efe1d6 ("power: reset: linkstation-poweroff: prepare for new devices") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Link: https://patch.msgid.link/20260407073025.271865-1-vulab@iscas.ac.cn Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman --- drivers/power/reset/linkstation-poweroff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/power/reset/linkstation-poweroff.c +++ b/drivers/power/reset/linkstation-poweroff.c @@ -163,10 +163,10 @@ static int __init linkstation_poweroff_i dn = of_find_matching_node(NULL, ls_poweroff_of_match); if (!dn) return -ENODEV; - of_node_put(dn); match = of_match_node(ls_poweroff_of_match, dn); cfg = match->data; + of_node_put(dn); dn = of_find_node_by_name(NULL, cfg->mdio_node_name); if (!dn)