From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2679034C9A6; Thu, 2 Jul 2026 16:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011119; cv=none; b=sMvCjw0tYRQuu0p3Fvuz61UZLkph57522j6ZZHclLZCOJOVggVNnWZMOpVtQSJXMgN7XjArrzyEEjDdlFxZcl410N4D9cYAysI0UQM7UOxVLbGQMB2XnIAmZtAoElxjGuVBIfkCz4qLwh77IDvDtLmPCZLDZ3mt0EDjADQE6aNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783011119; c=relaxed/simple; bh=Eeqi6eJ005o9dX9lusmkH1Kr0EYOSHeo9Fy9Kv82GRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S4Xp4gDv5Z5dbjiyV79N9T7pq8pemeG66vlPCXHI/UUqoZBlrMBmMT5SfqHMcDOvXSZ+ZIijSP7bBXz61vslP+BmaK9I6s7yOoFz2XAzDoDGDKab8Xh0jt4j4NY9VLQnC4HsIVVybMrgkJ0yYnVvlwsde1H6gaKL82sL0ANpzsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0GYtUNYv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0GYtUNYv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BAED1F000E9; Thu, 2 Jul 2026 16:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783011118; bh=8pN5nK7QTmNlRXgR8kbumypcomeHF9rQrh/pjMLM4C4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0GYtUNYv0oUUfKrXSjevGmNoJM+hoz8VU2+U5ge/7OsiXcPS39vZ9VujbbEukMtgB z4hIHQdkXZ8sRYaQjY5MGYOTnN+5jPnxbbaSoLyE/2X9yp2GDNC05EoiidYwWBAFSp qHNEbNkUxx/IqmZ7IXF30W96qvDkcAapecwxzRWE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guannan Wang , Chuck Lever Subject: [PATCH 6.6 163/175] NFSD: Fix SECINFO_NO_NAME decode error cleanup Date: Thu, 2 Jul 2026 18:21:04 +0200 Message-ID: <20260702155119.223867402@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702155115.766838875@linuxfoundation.org> References: <20260702155115.766838875@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guannan Wang commit 9e18e83b8846a5c3fe13fc8a464b4865d33996c6 upstream. nfsd4_decode_secinfo_no_name() currently initializes sin_exp after decoding sin_style. If the XDR stream is truncated, the decoder returns nfserr_bad_xdr before sin_exp is initialized. Since commit 3fdc54646234 ("NFSD: Reduce amount of struct nfsd4_compoundargs that needs clearing"), the inline iops array is not cleared between RPC calls. A failed SECINFO_NO_NAME decode can therefore leave sin_exp holding stale union contents from a previous operation. The error response path still invokes nfsd4_secinfo_no_name_release(), which calls exp_put() on a non-NULL sin_exp. Initialize sin_exp before the first failable decode step, matching nfsd4_decode_secinfo(). Fixes: 3fdc54646234 ("NFSD: Reduce amount of struct nfsd4_compoundargs that needs clearing") Cc: stable@vger.kernel.org Signed-off-by: Guannan Wang Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfs4xdr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -1821,10 +1821,11 @@ static __be32 nfsd4_decode_secinfo_no_na union nfsd4_op_u *u) { struct nfsd4_secinfo_no_name *sin = &u->secinfo_no_name; + + sin->sin_exp = NULL; if (xdr_stream_decode_u32(argp->xdr, &sin->sin_style) < 0) return nfserr_bad_xdr; - sin->sin_exp = NULL; return nfs_ok; }