From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00AA31ED7C; Thu, 16 Jul 2026 14:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784210641; cv=none; b=OvxP4cJfIrqu/G9eRPOi/hiuZLvXfZlMRpndCxYENtvAy+rZ8oIcDQmNUCm9TDFNOrYF7THTCmxkLZMH2Suf3tVu+mEjB7OHWEXI7bBl0crKrALfRGIU8AKIgb1hex998dedxFCT1YUAU/uceLEETLa0hi9fTZBp/ibHL4GZ900= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784210641; c=relaxed/simple; bh=1dtN28jwA1T+B1FZrYf/NLAzWoJfynn5GC/ekjthzM4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sL9t1oQISRkkSO7cHNp8xka7gaTjqQMtI7UaxcbDucIAqdK2w0RAog92jPl32qZB6uFyGvg6OQ+ZNr+W2d5SNB2z7Cyi2F89rareZfVPTDxf5aGz/JiFDBLPWEAxm0FHsMq5+a2C8pZYmntOytETce4fql9qZLzvnIemO89Y0bE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MhlM2nB9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MhlM2nB9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 411301F000E9; Thu, 16 Jul 2026 14:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784210639; bh=GEKEiPRgEHJOZ3MSWWFuGSM1O7ZMSW/Cwxi9Hldte3A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MhlM2nB9uRcMHFJgvUSNxM2ii2uXW4i7ceaX3nOTbtbIOMp85UmTFOzAsxNw7zTC6 KvWvg6lh3ZVw+Jycrk6cEZuPHVHIq/V1skVP/9UO9Ds/TbVmd1sXAyaHP2IUC00eI5 RDxu/+vEfDdEresar24gWKxv+8z7zmagWy7U4n7U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Paul Menzel , Johan Hovold , Luiz Augusto von Dentz Subject: [PATCH 6.18 123/480] Bluetooth: btusb: fix use-after-free on registration failure Date: Thu, 16 Jul 2026 15:27:50 +0200 Message-ID: <20260716133047.368042812@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133044.672218725@linuxfoundation.org> References: <20260716133044.672218725@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit eedc6867ebad73edbfaf9a0a65fbef7115cc4753 upstream. Make sure to release the sibling interfaces in case controller registration fails to avoid use-after-free and double-free when they are eventually disconnected. This issue was reported by Sashiko while reviewing a fix for a wakeup source leak in the btusb probe errors paths. Link: https://sashiko.dev/#/patchset/20260402092704.2346710-1-johan%40kernel.org Fixes: 9bfa35fe422c ("[Bluetooth] Add SCO support to btusb driver") Fixes: 9d08f50401ac ("Bluetooth: btusb: Add support for Broadcom LM_DIAG interface") Cc: stable@vger.kernel.org # 2.6.27 Reviewed-by: Paul Menzel Signed-off-by: Johan Hovold Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- drivers/bluetooth/btusb.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -4381,7 +4381,7 @@ static int btusb_probe(struct usb_interf err = hci_register_dev(hdev); if (err < 0) - goto out_free_dev; + goto err_release_siblings; usb_set_intfdata(intf, data); @@ -4390,6 +4390,15 @@ static int btusb_probe(struct usb_interf return 0; +err_release_siblings: + if (data->diag) { + usb_set_intfdata(data->diag, NULL); + usb_driver_release_interface(&btusb_driver, data->diag); + } + if (data->isoc) { + usb_set_intfdata(data->isoc, NULL); + usb_driver_release_interface(&btusb_driver, data->isoc); + } out_free_dev: if (data->reset_gpio) gpiod_put(data->reset_gpio);