From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7937B429CD6; Thu, 16 Jul 2026 14:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211102; cv=none; b=nszWV/CaVZePfUcNZuPAi1t/gx1a6W/qqmZVOonxKeBhO1od2I8oaZGS0xzd8qXgAlyl27gJVtyxJXzEdzW0Z2Pbo9eyq3wuUmarB6LDziWLCbrsq7zhqwID9PB0G4PqpRUQ6qYqsKrOUbBWfIEPaP8tRXMxDh2iPX20CqSA36w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211102; c=relaxed/simple; bh=9euzzIr6LE6ab9cuBOLWs3OMjIlUOUjDWNzupTehvRM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOoQfCQhBtqi3PftExSGIs0kT9ikVIzQIkTfOEtzg3vEsKML4zBU6wH5JvGDaZGrjgE9apfEt6g44M6c+Otz1jmHO0kFI2Hobzd0eDLoOZMQoRLUWPHbCt2I0MOMuiJHEYqSYDVLm4btLyo4Ug4urGu4L5SBauIdvxZ6w9JAFls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gLCIZ6Jj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gLCIZ6Jj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF3FB1F000E9; Thu, 16 Jul 2026 14:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784211101; bh=vSVFoOqsBz9FRrT0HTioL0z9F+M5F+kwDXQOYio0NCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gLCIZ6Jjt404R0WNExMztF8pp2R+p3UTFwUuI7SF55rc22bsxFaJfRGQphfL6jhr5 +t0iw86r7fZzUBIIhInxqrARendsT+Un43PUAacY6tXyZIMP8//plvLKdaqGNg0U1f PgQWpmPbbzjDdR7ZPMYzg1WpzTnMyRM2qhSdGQUI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Ijae Kim , Myeonghun Pak , Alex Henrie Subject: [PATCH 6.18 300/480] USB: misc: uss720: unregister parport on probe failure Date: Thu, 16 Jul 2026 15:30:47 +0200 Message-ID: <20260716133051.307374599@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133044.672218725@linuxfoundation.org> References: <20260716133044.672218725@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak commit b4ecbdc4f8830f5586c4a5cfc384c00f20f8f8b3 upstream. uss720_probe() registers a parport before reading the 1284 register used to detect unsupported Belkin F5U002 adapters. If get_1284_register() fails, the error path drops the driver private data and the USB device reference, but leaves the parport device registered. Leaving the port registered is more than a private allocation leak: parport_register_port() has already reserved a parport number and registered the parport bus device, while pp->private_data still points at the private data that the common error path is about to release. Undo the pre-announce registration in the get_1284_register() failure branch before jumping to the common private-data cleanup path. Clear priv->pp first, matching the disconnect path and avoiding a stale pointer in the private data. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 3295f1b866bf ("usb: misc: uss720: check for incompatible versions of the Belkin F5U002") Cc: stable Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Reviewed-by: Alex Henrie Link: https://patch.msgid.link/20260706151049.63470-1-mhun512@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/uss720.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -735,8 +735,11 @@ static int uss720_probe(struct usb_inter * here. */ ret = get_1284_register(pp, 0, ®, GFP_KERNEL); dev_dbg(&intf->dev, "reg: %7ph\n", priv->reg); - if (ret < 0) + if (ret < 0) { + priv->pp = NULL; + parport_del_port(pp); goto probe_abort; + } ret = usb_find_last_int_in_endpoint(interface, &epd); if (!ret) {