From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23B4136A004; Thu, 16 Jul 2026 13:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209825; cv=none; b=qyblXGEFj8yUfSLV2zeUdS2No8648tjPJ8x0s1MzxW5HcIVpPaL+ge0/97AUpYrd4MH3R7xt60yo5OUy19Aw1iXXArFiP3/5gvOvhifVOPEcna+1jlwV5ajNeXdDUzGMxvk/RWqrpD9+Fhbjgzb0+G+wm4+h8IbkFWoRhFBGj24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209825; c=relaxed/simple; bh=zPxHnEegSleejWeL5aQ/JZG+NKjyLilQBbRcE3xWldY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BvtPuRVPX4eZQ/FPyuxLm/Kf6UWN1acHnmIWrYl7MhnlPpdGnM5YCL14wGdF2qW9vF/h4gJyse6rUEtmFKtlFXCP31uha3k3yl00+sSnDR7DCMUdQRo3rwwBJ8wCAc8+qAOJKu9qQJ4pwoyqeaZ43tVEb4Mgn1EBCn70l5UsPWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ABE4a38N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ABE4a38N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C440B1F000E9; Thu, 16 Jul 2026 13:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784209823; bh=NXNSakhMl2d1mhpITI1bBi49dz1psY46ci51c7sDEsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ABE4a38Nfg7Lb7cDF9jeabcNfA+p/EN2AV5ADIXGyHSugIxpcPGCxcCGLOKOsCrkT Mqcl11dlff0y+gVFBrWlQCZH2acPYNF+6BNjrfkwIoL5UIudpQ8umc4VwVwl/dWbLN i6TG8A57aFC8vUq4qWRtnko0YWr72DfoXAlwF4p8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Andrei Kuchynski , Heikki Krogerus Subject: [PATCH 7.1 332/518] usb: typec: ucsi: Invert DisplayPort role assignment Date: Thu, 16 Jul 2026 15:30:00 +0200 Message-ID: <20260716133055.074253351@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133047.772246337@linuxfoundation.org> References: <20260716133047.772246337@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrei Kuchynski commit d092d7edf8faefa3e27b9fc7f0e7904b06c833a2 upstream. The existing implementation assigned these flags backwards, configuring the partner's DisplayPort role to match the port's role instead of complementing it. This prevents proper configuration during DP altmode activation, often causing `pin_assignment` to remain 0 in `dp_altmode_configure()` and resulting in VDM negotiation failures: [ 583.328246] typec port1.1: VDM 0xff01a150 failed Additionally, the fix ensures that the `pin_assignment` sysfs attribute displays the correct values. Cc: stable Fixes: af8622f6a585 ("usb: typec: ucsi: Support for DisplayPort alt mode") Signed-off-by: Andrei Kuchynski Reviewed-by: Heikki Krogerus Link: https://patch.msgid.link/20260601142837.3240207-1-akuchynski@chromium.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/ucsi/displayport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/usb/typec/ucsi/displayport.c +++ b/drivers/usb/typec/ucsi/displayport.c @@ -166,12 +166,12 @@ static int ucsi_displayport_status_updat * that Multi-function is preferred. */ if (DP_CAP_CAPABILITY(cap) & DP_CAP_UFP_D) { - dp->data.status |= DP_STATUS_CON_UFP_D; + dp->data.status |= DP_STATUS_CON_DFP_D; if (DP_CAP_UFP_D_PIN_ASSIGN(cap) & BIT(DP_PIN_ASSIGN_D)) dp->data.status |= DP_STATUS_PREFER_MULTI_FUNC; } else { - dp->data.status |= DP_STATUS_CON_DFP_D; + dp->data.status |= DP_STATUS_CON_UFP_D; if (DP_CAP_DFP_D_PIN_ASSIGN(cap) & BIT(DP_PIN_ASSIGN_D)) dp->data.status |= DP_STATUS_PREFER_MULTI_FUNC;