From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A86BF422E1D; Thu, 16 Jul 2026 13:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209943; cv=none; b=TyShzxqlGySs7OQO6QQGyxR3mLUgdzbGDi52wcFMw90yairfCd3Gf6T34HVG9owhUGKSSzlR5iTOwmM5+aEQpfUs6teDnW3Sztxh646IyNi3Rdj2IW5fGupQeoeCiUSIAaAfpKfPALoiGD7zKSt82D5DXTksRsjkalJfMEJD9tE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209943; c=relaxed/simple; bh=iArGt/carh7KJKBX/MldziLB5pBC56EdQmeaFPZAkHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PocOOJUaFGv8P6ZXNzWtBjbRZJlGTafOrcCXWePxUuXbajoE1bk4eEzVhh5k5Ab7t0TQ2SwOw5iLoMtNPHeLPujztV5sCKMXiKEZsxPkF+LkjvRd1gNVzOFR6vxeY1tu1u8iNTs6A3EiuK1glp37gsYYYua8XCB5lZnn/T3R/sM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tHbO50lj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tHbO50lj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE09A1F000E9; Thu, 16 Jul 2026 13:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784209941; bh=hReKrWf1MpXfNTtEyoJzm6s4+qFy0dGsqzmE77+snHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tHbO50ljW5WQu3bBQOZ3ry6v8TXEdxVsq8cNZMcVrmpmfB7clcGaX1p2Z/hkrrs2W Jie1nzFWmmEmzdQLZjTOAIFxCHP6eAIlMDMb7MNiLsT1TPTbx0lgNt1OMaZCLuTt3V WXd+C4wOL8WZgYQmah+kPsgQe4E48WTyzn7nyevw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Biggers , Herbert Xu Subject: [PATCH 7.1 377/518] crypto: drbg - Fix ineffective sanity check Date: Thu, 16 Jul 2026 15:30:45 +0200 Message-ID: <20260716133056.076042089@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133047.772246337@linuxfoundation.org> References: <20260716133047.772246337@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Biggers commit 040ad83b0e8aa065fd2fc641cacba8491a8b186d upstream. Fix drbg_healthcheck_sanity() to correctly check the return value of drbg_generate(). drbg_generate() returns 0 on success, or a negative errno value on failure. drbg_healthcheck_sanity() incorrectly assumed that it returned a positive value on success. This didn't make the sanity check fail, but it made it ineffective. Fixes: cde001e4c3c3 ("crypto: rng - RNGs must return 0 in success case") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/drbg.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/crypto/drbg.c +++ b/crypto/drbg.c @@ -1737,7 +1737,6 @@ static int drbg_kcapi_seed(struct crypto */ static inline int __init drbg_healthcheck_sanity(void) { - int len = 0; #define OUTBUFLEN 16 unsigned char buf[OUTBUFLEN]; struct drbg_state *drbg = NULL; @@ -1782,11 +1781,11 @@ static inline int __init drbg_healthchec max_request_bytes = drbg_max_request_bytes(drbg); drbg_string_fill(&addtl, buf, max_addtllen + 1); /* overflow addtllen with additional info string */ - len = drbg_generate(drbg, buf, OUTBUFLEN, &addtl); - BUG_ON(0 < len); + ret = drbg_generate(drbg, buf, OUTBUFLEN, &addtl); + BUG_ON(ret == 0); /* overflow max_bits */ - len = drbg_generate(drbg, buf, (max_request_bytes + 1), NULL); - BUG_ON(0 < len); + ret = drbg_generate(drbg, buf, max_request_bytes + 1, NULL); + BUG_ON(ret == 0); /* overflow max addtllen with personalization string */ ret = drbg_seed(drbg, &addtl, false);