From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7022633A9FC; Tue, 21 Jul 2026 22:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673149; cv=none; b=eTzaXYGIXnfHr4SCmwfGemCIe9RdSe7CKwcNSzAYL9WbcW9LP6WsN8l6rgCTTEFzD0U8Kj112HME3vXXjTRyHfa7SZYSaYQHq3Qj9870bd7SRkdjOyCSiACT4DYis5v4RXLFExb+JMIo0vtS8IEGAECVoQ0PQ53EhVm2wc1mjzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673149; c=relaxed/simple; bh=M4eSHxH+T3oSxjj8/fwjKfRf4dH/PChxRcks3ko5N2g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qXFGigoy56F6wL6Ej/wOB56iXxhAFSCnI+FLBZmGa6Bf6N3blZwei+tT5AMY26RnGDc5deO0GpiCTeZ9nMKLqnKgC97LpWCDWAJOcFrbHjspFeVvfK5W/lhXXydkSiwtaGlN2LK8L+9qhAQj1RNxYWbTZG539Zi6/6BbJchQtp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IIS+rgdT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IIS+rgdT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AF761F000E9; Tue, 21 Jul 2026 22:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673148; bh=wuKA0MyTTajgwgUbXKADHmhj0euAM9w7zErbCBDRtMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IIS+rgdTfRcc3CyUULZaFOt1Mqvuz9ngSuE2/RKJeKm7zyMwXK/dnU4uyuyjcIH0Z clp5lgXNk2anWbn18H7KYDml8sdZ5al7pDzG0zZDx2fnscH2wZf+6CBk8kbqy68+Qh fWsooegM7RvSuc03/u9SUOMfq8aIabjeQZ727R/U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Takashi Sakamoto , Maoyi Xie , Takashi Iwai Subject: [PATCH 5.10 053/699] ALSA: firewire: isight: bound the sample count to the packet payload Date: Tue, 21 Jul 2026 17:16:52 +0200 Message-ID: <20260721152356.906353780@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit 29b9667982e4df2ed7744f86b1144f8bb58eb698 upstream. isight_packet() takes the frame count from the device iso packet and checks it only against the device claimed iso length. count = be32_to_cpu(payload->sample_count); if (likely(count <= (length - 16) / 4)) isight_samples(isight, payload->samples, count); length is the iso header data_length. It can be up to 0xffff. So the gate allows a count up to about 16379. isight_samples() then copies count frames out of payload->samples into the PCM DMA buffer. payload->samples holds only 2 * MAX_FRAMES_PER_PACKET values. The device multiplexes two samples per frame. A count past MAX_FRAMES_PER_PACKET reads past the payload. A count past the buffer size writes past runtime->dma_area. The smallest PCM buffer is larger than MAX_FRAMES_PER_PACKET. Bounding the count to MAX_FRAMES_PER_PACKET keeps both the read and the write in range. A malicious or faulty Apple iSight on the FireWire bus reaches this during a normal capture. Add the MAX_FRAMES_PER_PACKET bound to the gate. Fixes: 3a691b28a0ca ("ALSA: add Apple iSight microphone driver") Suggested-by: Takashi Sakamoto Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Link: https://patch.msgid.link/178205454729.1900991.7807310178296762772@maoyixie.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/isight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/sound/firewire/isight.c +++ b/sound/firewire/isight.c @@ -179,7 +179,8 @@ static void isight_packet(struct fw_iso_ if (likely(length >= 16 && payload->signature == cpu_to_be32(0x73676874/*"sght"*/))) { count = be32_to_cpu(payload->sample_count); - if (likely(count <= (length - 16) / 4)) { + if (likely(count <= (length - 16) / 4 && + count <= MAX_FRAMES_PER_PACKET)) { total = be32_to_cpu(payload->sample_total); if (unlikely(total != isight->total_samples)) { if (!isight->first_packet)