From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4498F3AE6E4; Tue, 21 Jul 2026 22:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673186; cv=none; b=b1X4P3abZOUiMmCrzgVoYDFVkAyhtPHXVMc4Rl+a8gJkLpfXpv7KnkF6Ppxjx9HOknoxDT7WPTu5XIDk5kzDn6AvYyhuTeiOM0iFrW7M5xL/zGyx8dxZS5Rvy31YUaB5ppJ4h9pw7g5HEQvjXGA9HBKm6J0JHaeu6eVpZFuluaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673186; c=relaxed/simple; bh=xTpzCDH8ms128NYeCDmEtZGtEzy+VMsESySUXywH2xU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KDsLcOFjy5FPniSaXdAXt6g/zukXPwKDtzWr7hGngKObKfORKY5uELay8KvNR0D49qrp2jReyhlbMn0oevICTrfOzjwrtxnZP2gwe7EuoO0khrBPEHF1dY5vhGniag6s2O9TgPMJLeEWDrSTGPMviucLIcCZHu2p3c2YOyGGBw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fqj2SKFY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fqj2SKFY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A55061F000E9; Tue, 21 Jul 2026 22:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673185; bh=NwRDV3Lxoxwt8uB7VQpTHfbbgVKAEUc5WJaPD6m6Was=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fqj2SKFYYZglD8EyG1f/xNRiSAPbMy99od7ykxksdV8yObQtMyQee8MLgCT8u7rzN g7lG1pNStB5GnJ4j83j7zvC+g4RqKRQVqf7fcW/6Jh+AUfDP0GF1V4josHWHtJ9qyE x0dqfx7HEYqVW5jSt+D1jQG/kdjmAQGN7nOCHMyw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pawel Moll , Johan Hovold , "Michael S. Tsirkin" Subject: [PATCH 5.10 066/699] virtio-mmio: fix device release warning on module unload Date: Tue, 21 Jul 2026 17:17:05 +0200 Message-ID: <20260721152357.190922336@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit c687bc35694698ec4c7f92bf929c3d659f0cecb8 upstream. Driver core expects devices to be allocated dynamically and complains loudly when a device that lacks a release function is freed. Use __root_device_register() to allocate and register the root device instead of open coding using a static device. Note that root_device_register(), which also creates a link to the module, cannot be used as the device is registered when parsing the module parameters which happens before the module kobject has been set up. Fixes: 81a054ce0b46 ("virtio-mmio: Devices parameter parsing") Cc: stable@vger.kernel.org # 3.5 Cc: Pawel Moll Signed-off-by: Johan Hovold Signed-off-by: Michael S. Tsirkin Message-ID: <20260427143710.14702-1-johan@kernel.org> Signed-off-by: Greg Kroah-Hartman --- drivers/virtio/virtio_mmio.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -675,9 +675,7 @@ static int virtio_mmio_remove(struct pla #if defined(CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES) -static struct device vm_cmdline_parent = { - .init_name = "virtio-mmio-cmdline", -}; +static struct device *vm_cmdline_parent; static int vm_cmdline_parent_registered; static int vm_cmdline_id; @@ -685,7 +683,6 @@ static int vm_cmdline_id; static int vm_cmdline_set(const char *device, const struct kernel_param *kp) { - int err; struct resource resources[2] = {}; char *str; long long int base, size; @@ -717,11 +714,10 @@ static int vm_cmdline_set(const char *de resources[1].start = resources[1].end = irq; if (!vm_cmdline_parent_registered) { - err = device_register(&vm_cmdline_parent); - if (err) { - put_device(&vm_cmdline_parent); + vm_cmdline_parent = __root_device_register("virtio-mmio-cmdline", NULL); + if (IS_ERR(vm_cmdline_parent)) { pr_err("Failed to register parent device!\n"); - return err; + return PTR_ERR(vm_cmdline_parent); } vm_cmdline_parent_registered = 1; } @@ -732,7 +728,7 @@ static int vm_cmdline_set(const char *de (unsigned long long)resources[0].end, (int)resources[1].start); - pdev = platform_device_register_resndata(&vm_cmdline_parent, + pdev = platform_device_register_resndata(vm_cmdline_parent, "virtio-mmio", vm_cmdline_id++, resources, ARRAY_SIZE(resources), NULL, 0); @@ -756,8 +752,12 @@ static int vm_cmdline_get_device(struct static int vm_cmdline_get(char *buffer, const struct kernel_param *kp) { buffer[0] = '\0'; - device_for_each_child(&vm_cmdline_parent, buffer, - vm_cmdline_get_device); + + if (vm_cmdline_parent_registered) { + device_for_each_child(vm_cmdline_parent, buffer, + vm_cmdline_get_device); + } + return strlen(buffer) + 1; } @@ -779,9 +779,9 @@ static int vm_unregister_cmdline_device( static void vm_unregister_cmdline_devices(void) { if (vm_cmdline_parent_registered) { - device_for_each_child(&vm_cmdline_parent, NULL, + device_for_each_child(vm_cmdline_parent, NULL, vm_unregister_cmdline_device); - device_unregister(&vm_cmdline_parent); + root_device_unregister(vm_cmdline_parent); vm_cmdline_parent_registered = 0; } }