From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB8444AB6A; Tue, 21 Jul 2026 22:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673212; cv=none; b=jjYdM0jD6hVFZd7uU1fbcExfejVJZhprtLASIBU9fNMxD32LmHIZHTKQZ2qiebIChnvvdKYnS3i3o294rx6zwyZvZ8agyror0jbgsLF1mgEamjbw0VOAe2HAJJz+qDDjZQZbf/5KDHcfm9KXzNhYrrn8MOJLmxBLE7itDXUgKKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673212; c=relaxed/simple; bh=SDv1Om68Wk2GObHvfpV6RKbNwjNPbrKu13P0CNHUjtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DSxM35WQr82iVi99/tbF45dwFe4kHIXnK4/X6pgRkesi7TttjfWIt34l7zNVqrGSW2HMtSXQ1PLWWUF3P46m1RvSbpOd5+9eiwIDl9OCmKhSPIjab2A9EVq6dojlLtEYEk9pNBo8Wp9TiNppGCxc5RdvnHnNlXl4rb4oZtYqIxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WxBFyWOT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WxBFyWOT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2DCA1F000E9; Tue, 21 Jul 2026 22:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673211; bh=AI1/WxkXo/C4gGLQ+4Pvx2bmYpX63Q2ijHd2sdOw/9Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WxBFyWOTjwZBfyieN6fvMy9uCuMTv/5TmWiUJkViAVHY1jbaOlwiCG/Py/zUYahjA 99ydCsKnkyhB3f90H07ReGK5lJuDXUnoQ5DxHzzOQ1Z36vKY+IXWX2YFIStP5Ccs0W 6uMB1/x6GvLYvm8azlpeWM7WVVeLovrctO3o/BxE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+5e8dda76ca21dae314b6@syzkaller.appspotmail.com, Thomas Gleixner Subject: [PATCH 5.10 075/699] debugobjects: Plug race against a concurrent OOM disable Date: Tue, 21 Jul 2026 17:17:14 +0200 Message-ID: <20260721152357.397620097@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Gleixner commit b81dde13cc163450dcb402dcc915ef13ba241e01 upstream. syzbot reported a puzzling splat: WARNING: kernel/time/hrtimer.c:443 at stub_timer+0xa/0x20 stub_timer() is installed as timer callback function in hrtimer_fixup_assert_init(), which is invoked when debug_object_assert_init() can't find a shadow object. In that case debug objects emits a warning about it before invoking the fixup. Though the provided console log lacks this warning and instead has the following a few seconds before the splat: ODEBUG: Out of memory. ODEBUG disabled So the object was looked up in debug_object_assert_init() and the lookup failed due a concurrent out of memory situation which disabled debug objects and freed the shadow objects: debug_object_assert_init() if (!debug_objects_enabled) return; obj = alloc(); if (!obj) { // Out of memory debug_objects_enabled = false; free_objects(); obj = lookup_or_alloc(); // The lookup failed because the other side // removed the objects, so this returns // an error code as the object in question // is not statically initialized if (!IS_ERR_OR_NULL(obj)) return; if (!obj) { debug_oom(); return; } print(...) if (!debug_objects_enabled) return; fixup(...) The debug object splat is skipped because debug_objects_enabled is false, but the fixup callback is invoked unconditionally, which makes the timer disfunctional. This is only a problem in debug_object_assert_init() and debug_object_activate() as both have to handle statically initialized objects and therefore must handle the error pointer return case gracefully. All other places only handle the found/not found case and the NULL pointer return is a signal for OOM. Otherwise they get a valid shadow object. Plug the hole by checking whether debug objects are still enabled before invoking the print and fixup function in those two places. Fixes: b84d435cc228 ("debugobjects: Extend to assert that an object is initialized") Reported-by: syzbot+5e8dda76ca21dae314b6@syzkaller.appspotmail.com Signed-off-by: Thomas Gleixner Cc: stable@vger.kernel.org Link: https://patch.msgid.link/874iiwlzlb.ffs@fw13 Signed-off-by: Greg Kroah-Hartman --- lib/debugobjects.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) --- a/lib/debugobjects.c +++ b/lib/debugobjects.c @@ -722,6 +722,14 @@ int debug_object_activate(void *addr, co } raw_spin_unlock_irqrestore(&db->lock, flags); + + /* + * lookup_object_or_alloc() might have raced with a concurrent + * allocation failure which disabled debug objects. + */ + if (!debug_objects_enabled) + return 0; + debug_print_object(&o, "activate"); switch (o.state) { @@ -899,6 +907,15 @@ void debug_object_assert_init(void *addr return; } + /* + * lookup_object_or_alloc() might have raced with a concurrent + * allocation failure which disabled debug objects. Don't run the fixup + * as it might turn a valid object useless. See for example + * hrtimer_fixup_assert_init(). + */ + if (!debug_objects_enabled) + return; + /* Object is neither tracked nor static. It's not initialized. */ debug_print_object(&o, "assert_init"); debug_object_fixup(descr->fixup_assert_init, addr, ODEBUG_STATE_NOTAVAILABLE);