From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C825367B63; Tue, 21 Jul 2026 22:34:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673294; cv=none; b=Szg5xmNEsxiTWTo4xMY8hnO/P04paTBOofrLveKwK9OsRM2u2wpHrnMbMH2TQmAN0oq7lw36QQIuZ1f/WFD7kGJ8TtsH6/uNGnmfd0Ez1bOFTexWhkUzfIfPQSOUIU9VjhmIq9n3sESkHdnq4V3+kogVvE2cao6jhwZp+By3XJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673294; c=relaxed/simple; bh=Fpwhn92DONnqFdRfm8WCDxixZY2na0MGza1HpNfsH1E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dbZJfCvcpPyA+5AaGTus1S3TPoP2wS+mvyeWtsFmOjo++mW6qTqb6r1R2QSwT5U+qSc0UQNAwMSTS7RuzY0bQ2fcRiIQRmGkO52YXhdJ+/xcNMuZo2dPIwaCTly/HGULMuh2sqFAZAubk1DzavooKNy3EQmhGz4Vmh9Cfd6Z6I8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LGzfQnYH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LGzfQnYH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1D1E1F00A3A; Tue, 21 Jul 2026 22:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673293; bh=Oo1KqSOnmNS494S1CSgJav67mUIjBjxjw5RIdTmVPCs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LGzfQnYH4zKc/ljxDNCng6zdA+e9glxI668+WkfpvXYF30CDizMjcIFI0zRtmuMX/ /Ipx0qHYllHr7HKVdzGHnHMl839XK1o9Jn8QDhUldkS2m5Xdhg7WpFxYmX2tPzTQDP iEF5l4bcAT/FdrLpsV6HjXcnbt6Id1d/zbbWBc/s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Haoxiang Li Subject: [PATCH 5.10 108/699] usb: mtu3: unmap request DMA on queue failure Date: Tue, 21 Jul 2026 17:17:47 +0200 Message-ID: <20260721152358.139348160@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li commit 0bddda5a11665c210339de76d27ebbd1a2e0b43c upstream. mtu3_gadget_queue() maps the request before checking whether the QMU GPD ring can accept another transfer. the request is returned with -EAGAIN before it is linked on the endpoint request list if mtu3_prepare_transfer() fails. Normal completion and dequeue paths unmap requests from mtu3_req_complete(), but this error path never reaches that helper, so the DMA mapping is left active. Unmap the request before returning from the failed queue path. Fixes: df2069acb005 ("usb: Add MediaTek USB3 DRD driver") Cc: stable Signed-off-by: Haoxiang Li Link: https://patch.msgid.link/20260623093325.2105323-1-haoxiang_li2024@163.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/mtu3/mtu3_gadget.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -305,6 +305,7 @@ static int mtu3_gadget_queue(struct usb_ if (mtu3_prepare_transfer(mep)) { ret = -EAGAIN; + usb_gadget_unmap_request(&mtu->g, req, mep->is_in); goto error; }