From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 308CE3DDB03; Tue, 21 Jul 2026 22:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673305; cv=none; b=sJBvEwTr2rVAxWXyLHWSvPSu1M2e5kurqBmENUb0iaOQC1BuyIDTGBETlR83KAYV4Gx+WrxvczBee60JnTYWvmK+7rjku+OoTnP9dXpOmFB+puJ6+xYcIJaNrEx9KfAqhcnps3gIBzxR3+d2JhxfDaUSrIp6iWiuLwbLCD9iaE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673305; c=relaxed/simple; bh=B07u8Ld2kN/xAUmbkqHvhpE7Xwi4uNbhKwPLzUapkaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gQzp9Dr04XirjHgXb5HWrdnAEr8Dph0ACwZkI/b9aNRDbwqMIb8/V6Pr3x0UvRZnf593CzkDUC6kyrUPQuwl93hA/RPQujt/A9aSUZOvVskpXC3KZmkNctXIaJZc6zT3RpPbWWVKtl19OGJfPESkyqA3Sr6zkncarCGREgpCImM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EpmOOTR8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EpmOOTR8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AE4F1F000E9; Tue, 21 Jul 2026 22:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673304; bh=p3bjY99HP2jRb223qPJaoJIXyH6gpx1RCBLYeLdoc70=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EpmOOTR8kKJVl2IkORQyjUqqtn721m8kSS7E8CFeuLcF4lYqgCIKEGIOMkyrRxqrC wzZ9UFMtculsoOHfWng9tszSOD2ZMDBNwiMrUb619CEjEt2EMJxIvwVWRIwFy7w8Fn EBYxvIsJP7I8Mg9HbbUBuB6pokGRhDhPrP9IM6Cg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold Subject: [PATCH 5.10 111/699] USB: serial: digi_acceleport: fix hard lockup on disconnect Date: Tue, 21 Jul 2026 17:17:50 +0200 Message-ID: <20260721152358.206583462@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 5c1ea24b53bf3bfb859f0a05573997487975da23 upstream. If submitting the OOB write urb fails persistently (e.g if the device is being disconnected) the driver would loop indefinitely with interrupts disabled. Check for urb submission errors when sending OOB commands to avoid hanging if, for example, open(), set_termios() or close() races with a physical disconnect. This is issue was flagged by Sashiko when reviewing an unrelated change to the driver. Link: https://sashiko.dev/#/patchset/20260610132232.356139-1-johan%40kernel.org?part=1 Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/digi_acceleport.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) --- a/drivers/usb/serial/digi_acceleport.c +++ b/drivers/usb/serial/digi_acceleport.c @@ -394,12 +394,14 @@ static int digi_write_oob_command(struct len &= ~3; memcpy(oob_port->write_urb->transfer_buffer, buf, len); oob_port->write_urb->transfer_buffer_length = len; + ret = usb_submit_urb(oob_port->write_urb, GFP_ATOMIC); - if (ret == 0) { - oob_priv->dp_write_urb_in_use = 1; - count -= len; - buf += len; - } + if (ret) + break; + + oob_priv->dp_write_urb_in_use = 1; + count -= len; + buf += len; } spin_unlock_irqrestore(&oob_priv->dp_port_lock, flags); if (ret)