From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 705713AA4F9; Tue, 21 Jul 2026 22:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673322; cv=none; b=bpYBBndNYmzkco9LSGKwlGbqtvpBvJjb37oj22fzaFrhUWB+o5nNw+XPQ1CKBq4pYxHYjz6Q83x52SYE+fLXORvNSSx0vF+HRUfyJKuI7CR5RWKK41QPLVTO2AXNSFmEsSqJsn16+iiyKFXoUTy5S+YjF9yuIQqwgK8PT4wlajc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673322; c=relaxed/simple; bh=HoRQXBhy0PAY44o2x1DOUCJnqCwUhVQy9O60Is4IIP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hre/MbLFdlnkXTUMokLicPgrDL2WVpZDClT1cPDKLFMNQnFbykD19o4bdnz61AbZWahP2+XnPH9KaySOEEvJds1XBzOYu0COWSCgyFHlMgTH3tRrIHWjIbJqxn7KFT4xfIT16g8Nq35GynZQtLx9W+idw68Fx3MVXwwvrZAjmeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=X6n7TAZb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="X6n7TAZb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 979521F000E9; Tue, 21 Jul 2026 22:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673320; bh=77PoUfZI1CIn2lmDdjUCsXAXCg90QHb1q1mlO1CSpvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=X6n7TAZbIeFuWf7eI55nynXky26M76MjefetqquRJyfRb+3MbDRLetKZPx/Apnrxl n6B70tYg1qZbD+iFzUJPumZHAgLzhXLcxCk0HCua0O+lZqL8tGVKAAj3yHutu1xqu4 ZG8PFGsSAyNc5WSkIycw4/Bg8sqZusRla8DmhBSI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Andrei Kuchynski , Heikki Krogerus Subject: [PATCH 5.10 117/699] usb: typec: ucsi: Invert DisplayPort role assignment Date: Tue, 21 Jul 2026 17:17:56 +0200 Message-ID: <20260721152358.344882977@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrei Kuchynski commit d092d7edf8faefa3e27b9fc7f0e7904b06c833a2 upstream. The existing implementation assigned these flags backwards, configuring the partner's DisplayPort role to match the port's role instead of complementing it. This prevents proper configuration during DP altmode activation, often causing `pin_assignment` to remain 0 in `dp_altmode_configure()` and resulting in VDM negotiation failures: [ 583.328246] typec port1.1: VDM 0xff01a150 failed Additionally, the fix ensures that the `pin_assignment` sysfs attribute displays the correct values. Cc: stable Fixes: af8622f6a585 ("usb: typec: ucsi: Support for DisplayPort alt mode") Signed-off-by: Andrei Kuchynski Reviewed-by: Heikki Krogerus Link: https://patch.msgid.link/20260601142837.3240207-1-akuchynski@chromium.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/ucsi/displayport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/usb/typec/ucsi/displayport.c +++ b/drivers/usb/typec/ucsi/displayport.c @@ -150,12 +150,12 @@ static int ucsi_displayport_status_updat * that Multi-function is preferred. */ if (DP_CAP_CAPABILITY(cap) & DP_CAP_UFP_D) { - dp->data.status |= DP_STATUS_CON_UFP_D; + dp->data.status |= DP_STATUS_CON_DFP_D; if (DP_CAP_UFP_D_PIN_ASSIGN(cap) & BIT(DP_PIN_ASSIGN_D)) dp->data.status |= DP_STATUS_PREFER_MULTI_FUNC; } else { - dp->data.status |= DP_STATUS_CON_DFP_D; + dp->data.status |= DP_STATUS_CON_UFP_D; if (DP_CAP_DFP_D_PIN_ASSIGN(cap) & BIT(DP_PIN_ASSIGN_D)) dp->data.status |= DP_STATUS_PREFER_MULTI_FUNC;