From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E981134DCE4; Tue, 21 Jul 2026 22:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673595; cv=none; b=Ng2DE0F2TmabkbxO85aSleeNpx133b9aTsTbi0tr9WkDnwrMYJ1otgMG7Bcwh05WXNd6VuSsWppNLVUaVYb0jkLbZVRYtp9wZdLN9uZpKeNktgYkVZRlwd+AXq9dLV0HE11gaMBWLAdLzWbNReh0cZl5BzWDnUNbELmg7MASxoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673595; c=relaxed/simple; bh=+R3F1jMLT4ki6W1bVQDrA2xk2bjVe3IkGBqSxHRcsDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c2ixwtbqHP6/e7Y7AviMaJPK3Y9Hy0AbFujmBS/+s6E9gkCyJNR62TyUIG+1r+V2mflVFiSIgWkToi1kVumMBnbcRbhsDFDC4XfjeGCVb32c7DP1d2Wn1TF+QcXe8apEeEYeNBnjR8oDWkK7t7ftggbOmE2XDOpKB+F7peWUgdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uB7UBEqJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uB7UBEqJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D14221F000E9; Tue, 21 Jul 2026 22:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673593; bh=foHhq6irDVDF0LH7QuEMA7N1TrEktkteWIjbb6eJCHM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uB7UBEqJcDzzPTz0p+Zh7PDWJurxPc8iRozvQhuuqQ0KSJEVRcxTp//CeKb25V6Hz c97Sc0GQ4O6WGUJ7yXDMiyt9BdmI7zTgSZ4gSVwsyQYdYYZu6lrYFJJmnDdah0XFOj GN8bpTZMp4uG0bOQGnc4CEbSWpb6oZSodObeQza8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Samuel Holland , Andrey Skvortsov , Paul Kocialkowski , Nicolas Dufresne , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 177/699] media: cedrus: Fix failure to clean up hardware on probe failure Date: Tue, 21 Jul 2026 17:18:56 +0200 Message-ID: <20260721152359.692780880@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Samuel Holland [ Upstream commit f0a22f1d602ed499a192284de5e811a73421f0c7 ] If V4L2 device fails to register, then SRAM still be claimed and as a result driver will not be able to probe again. cedrus 1c0e000.video-codec: Failed to claim SRAM cedrus 1c0e000.video-codec: Failed to probe hardware cedrus 1c0e000.video-codec: probe with driver cedrus failed with error -16 cedrus_hw_remove undoes everything that was previously done by cedrus_hw_probe, such as disabling runtime power management and releasing the claimed SRAM and reserved memory region. Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") Acked-by: Paul Kocialkowski Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/staging/media/sunxi/cedrus/cedrus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index 28de90edf4cc59..d761ee3f33e5c5 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -420,7 +420,7 @@ static int cedrus_probe(struct platform_device *pdev) ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev); if (ret) { dev_err(&pdev->dev, "Failed to register V4L2 device\n"); - return ret; + goto err_hw; } vfd = &dev->vfd; @@ -481,6 +481,8 @@ static int cedrus_probe(struct platform_device *pdev) v4l2_m2m_release(dev->m2m_dev); err_v4l2: v4l2_device_unregister(&dev->v4l2_dev); +err_hw: + cedrus_hw_remove(dev); return ret; } -- 2.53.0