From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA0223C1400; Tue, 21 Jul 2026 22:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673667; cv=none; b=WOGHSIPh5g/u2j2wdBIUoPF/zUZjS885NwjtN1Z1C73pTOcqYsYrOrMMYxPp9nI8FxnAR2UI+2bgz16JlCU2d2ZLkFbQxYtgDi1Kh8hYB4LiVQ96GGcB8jQRfGOEs7U+P0ot1jw3/BJbGOni86anHkIRwr/Z/ukgDjjbdEwimg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673667; c=relaxed/simple; bh=YoYNZUoW3qK8njDkErxLWULT6RwKEcIY/bKAmzBd31E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YQEU5MgqooRIsbHV7hItGz8NE9eK+HaFrDYsgtH462cAQ1+eTASgDOT3FgzCzeuPDyePZwdwfhR9yG2XdNjJ1Ep1JJTaEKNM/P7JSgtGZUqcEsTiBr5uTxEs7agCfozqmCqIqVbUp2xA7N/3/d6U/XeC/cAX/fqr4BdSZZEIOfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=No8ipNob; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="No8ipNob" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B23E1F000E9; Tue, 21 Jul 2026 22:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673666; bh=j9Iwu2Qb/4Qz+MHW1z7DjySEslAG2A7RIDCgLfGu6Kg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=No8ipNobNTIXz8VrCzqVfFl6iObeSSUNQoDoDgfFEe71S4dBFZaRRXINUr1h5VD1b qXyYocVMBSUBbNjLe+5RG7U1DVVhDWwk2ItQVF1eFkQzDCwabHJ3roFXt6vD5Mor0E cmsvFj6KdxEooWX/f7he1puWzryZVfO45u5WPvkk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Jack Wang , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 222/699] scsi: pm8001: Fix error code in non_fatal_log_show() Date: Tue, 21 Jul 2026 17:19:41 +0200 Message-ID: <20260721152400.707803929@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 1b6f03b7ae9ee27054c55bb55a69d05555a78516 ] The non_fatal_log_show() function is supposed to return negative error codes on failure. But because the error codes are saved in a u32 and then cast to signed long, they end up being high positive values instead of negative. Remove the intermediary u32 variable to fix this bug. Fixes: dba2cc03b9db ("scsi: pm80xx: sysfs attribute for non fatal dump") Signed-off-by: Dan Carpenter Acked-by: Jack Wang Link: https://patch.msgid.link/ahs-bEsBJH0KhnsX@stanley.mountain Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_ctl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index d5d5965fa7a0e9..467f77664efb90 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -588,10 +588,7 @@ static DEVICE_ATTR(fatal_log, S_IRUGO, pm8001_ctl_fatal_log_show, NULL); static ssize_t non_fatal_log_show(struct device *cdev, struct device_attribute *attr, char *buf) { - u32 count; - - count = pm80xx_get_non_fatal_dump(cdev, attr, buf); - return count; + return pm80xx_get_non_fatal_dump(cdev, attr, buf); } static DEVICE_ATTR_RO(non_fatal_log); -- 2.53.0