From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C2363B6C17; Tue, 21 Jul 2026 22:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673657; cv=none; b=drZAtNgfDuoG2cN3LHdCUmaGj3Qx63GFWGdjqxSIIaTrOiXJEcVGLDSq37TOpd+eg0o6NGC+06dYE0TDZPan3nmD6TCHSHYOjUMDeZBCf+orA9arNykoUGX2UxAP0rRGvjJ7MiShHwNha0goKCQ1XqtxvbSMzTMNEOVhJUbuFVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673657; c=relaxed/simple; bh=ZmtvwtrhdNHBs0MZHlXuGeopz9/BqT0XBk5bEHo7UUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cTsuEMZJMbe7gCieMNx1TRb3/2hGCk6yPJ4HeAwBdg+f7N8k16fxhD0xidNfMRFTKtyNgzurM4ce4DbTLkiZ41CE1KTvH5l+k0rkId3PK4upq1uW5FKunVBYDER9hjasRJnVT8A1Mz8WsElWRoUETs3WAfi8go1Sjsi1koJ6arA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rUFOq4Ax; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rUFOq4Ax" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B706F1F000E9; Tue, 21 Jul 2026 22:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673656; bh=66y3cSRESeq7UtFt6yVrbXhTr+Cvh3XKppY032DEEj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rUFOq4Ax6xfCT9b3b4bMcXSkJ/o7FUee37UxTUaL3G+7fVo4oX0nWaxqtrLMDY3Vw uRZJfnCeBosS8FekLjuBN0AjKPyfb/k8L/Ds8HFmtZEeqwH01knYO6NwNKTDzlyVWK GfzVdiJ5c+GT14hCRwVuxhRYC6kQSyi1pSUemaQc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wolfram Sang , Konrad Dybcio , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.10 245/699] hwspinlock: qcom: avoid uninitialized struct members Date: Tue, 21 Jul 2026 17:20:04 +0200 Message-ID: <20260721152401.225015783@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wolfram Sang [ Upstream commit 8752c396ce3b2136b3d4c906fe103f6efb6782d9 ] The reg_field is allocated on stack, so using the REG_FIELD macro will ensure that unused members do not have uninitialized values. Fixes: 19a0f61224d2 ("hwspinlock: qcom: Add support for Qualcomm HW Mutex block") Link: https://sashiko.dev/#/patchset/20260319105947.6237-1-wsa%2Brenesas%40sang-engineering.com Signed-off-by: Wolfram Sang Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20260512091339.31085-2-wsa+renesas@sang-engineering.com Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/hwspinlock/qcom_hwspinlock.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index e4991466486397..6a2a2f3e618554 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -129,7 +129,6 @@ static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *pdev, static int qcom_hwspinlock_probe(struct platform_device *pdev) { struct hwspinlock_device *bank; - struct reg_field field; struct regmap *regmap; size_t array_size; u32 stride; @@ -151,9 +150,7 @@ static int qcom_hwspinlock_probe(struct platform_device *pdev) platform_set_drvdata(pdev, bank); for (i = 0; i < QCOM_MUTEX_NUM_LOCKS; i++) { - field.reg = base + i * stride; - field.lsb = 0; - field.msb = 31; + struct reg_field field = REG_FIELD(base + i * stride, 0, 31); bank->lock[i].priv = devm_regmap_field_alloc(&pdev->dev, regmap, field); -- 2.53.0