From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CCB03BB680; Tue, 21 Jul 2026 22:42:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673770; cv=none; b=j8G7SZU5H5kzMFhJEbtSW2NxbG8NWDJWweOLVL77SQ7ak1TEcJX7bIbpxxw43we6lApTym+S61VAcJ0Otpl3jyo17nbG0rIqS9kafhBZ2eUT7UcK9booNi5eqJNmOPXlYSOl53PJz/30lPmbLtV5FRDh3V9B6coeyD2JDYOjpdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673770; c=relaxed/simple; bh=Ut0iLBTtJNisZBRY9U+99ASfMpUlSNfh3+SinMj7NyA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uQlt1gw4b70KFF5Nd6qUHhIBHw3XWtrvfBXyGw/eJxaEumSeqB+CQUwbD6my00Zrs7Gcvnf1XJK8F9m7chufQe9jvbs65ZuGQEx4U22tSIOTnomKF9sLuDuMPlXtNZhyOivxb4zwmZzlYAMTXCxdlHXtwdfUe3ChU2D6iq/quTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J9SJUsAF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J9SJUsAF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DCFE1F000E9; Tue, 21 Jul 2026 22:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673769; bh=6iwjLOd7DiL1egDRcO0H418js/CO8czt7vRGm4I56lk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=J9SJUsAFgM7tFEWq5Dz2M11cJ8uLfL2DRonX+aFetlFT/NjiY4cZdP/BQVyp37B9B 4zrLFAd+l3GZeoJG4l1uaQhz6ovcTyU2O8POwyB7EnOsyGrUL1N+zvBGWFCMa/SpgA 4uld67dchKU43lq9ThYkzbobnOe8f+dqkialeS6Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, James Kim , Sasha Levin Subject: [PATCH 5.10 288/699] char: tlclk: fix use-after-free in tlclk_cleanup() Date: Tue, 21 Jul 2026 17:20:47 +0200 Message-ID: <20260721152402.196924461@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: James Kim [ Upstream commit bbf003b7794d6ad6f939fdd29f1f1bde8ac554c1 ] This patch improves the module cleanup process in the tlclk driver to prevent potential use-after-free and race conditions. Currently, the file_operations structure does not specify the .owner field, which could allow the module to be unloaded while user-space processes are still interacting with the device. Additionally, the tlclk_cleanup() function frees the alarm_events memory before ensuring that blocked processes in the waitqueue are fully awakened and that the switchover_timer has completed. To address these cases, this patch: - Sets '.owner = THIS_MODULE' in tlclk_fops to safely defer module unloading while the device is in use. - Updates tlclk_cleanup() to explicitly wake up all blocked readers (wake_up_all), properly release hardware I/O regions, and safely delete the timer (timer_delete_sync) prior to freeing memory. Fixes: 1a80ba882730 ("[PATCH] Telecom Clock Driver for MPCBL0010 ATCA computer blade") Signed-off-by: James Kim Link: https://patch.msgid.link/20260503101131.64219-1-james010kim@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/char/tlclk.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c index 896a3550fba9f3..6b993744f2d781 100644 --- a/drivers/char/tlclk.c +++ b/drivers/char/tlclk.c @@ -263,6 +263,7 @@ static ssize_t tlclk_read(struct file *filp, char __user *buf, size_t count, } static const struct file_operations tlclk_fops = { + .owner = THIS_MODULE, .read = tlclk_read, .open = tlclk_open, .release = tlclk_release, @@ -852,6 +853,9 @@ static void __exit tlclk_cleanup(void) misc_deregister(&tlclk_miscdev); unregister_chrdev(tlclk_major, "telco_clock"); + got_event = 1; + wake_up_all(&wq); + release_region(TLCLK_BASE, 8); del_timer_sync(&switchover_timer); kfree(alarm_events); -- 2.53.0