From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23F844071DE; Tue, 21 Jul 2026 22:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673823; cv=none; b=TeiNmmnvGygAhAdoMFfGDTc3BMkgFj/GjMkhRW5HwRd4aUZ+Zm385/1MhK63eyl8xVgR4lEHN/bKnmHKTU+hr/j/kahCpKMqPg6HJp+5jiP0pA9bUkT9pVYgo4auT76rww+c0oZPXISheusVW3tTcqKFv8yZIP0QuZvhFYGOfXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673823; c=relaxed/simple; bh=9auIjT4e4i1eikYlhrhKEtYF4zIFLdFVllwuEwmCDsE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cg+4t+zWf4bCPqktYkYQ5JTmgT7a275mqtR1BI28+BJLP/iM7eZv5941hWEUAhEVqAVjiMQxi/y1HwANOll1RZZBd7Wkyq2MZSHiUvCk98Iv98QyBV3M6zcOcyZLcm2NhnS3pnOfF/4aKUEJ5QD787Uk4YIFHFwy8dSsgD0KSF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rHenj3k7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rHenj3k7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89C741F000E9; Tue, 21 Jul 2026 22:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673822; bh=q35OXSnGcBqKXebXrKi6JnK4nGue6IINANohlSa6hCc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rHenj3k7jtcRnKWn4G2glRWebT+99hO6vGFyAejJOYHQsZpnHWqeh4bVq0D+uyCET Agtwfig3hOMbl4GGjJkGHc9Uv07mCKcGfRASRMRWT0m1FzSgwBUld4dNS/QNmnR7kv eRA9vbb7fU/X5TUmJUstX5CdxQW+sXaRzJv9IjXs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot , Ian Rogers , Don Zickus , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.10 306/699] perf tools: Fix get_max_num() size_t underflow on empty sysfs file Date: Tue, 21 Jul 2026 17:21:05 +0200 Message-ID: <20260721152402.598107135@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaldo Carvalho de Melo [ Upstream commit 0a012113bb3a44482c163f16f4db03ccaa37a339 ] get_max_num() reads a sysfs file (cpu/possible, cpu/present, or node/possible) and scans backward from the end to find the last number. If the file is empty, filename__read_str() returns num == 0. The loop `while (--num)` decrements the size_t from 0 to SIZE_MAX, reading backward across the heap until a comma or hyphen is found or unmapped memory is hit. Add an early return for empty files before the backward scan. Fixes: 7780c25bae59fd04 ("perf tools: Allow ability to map cpus to nodes easily") Reported-by: sashiko-bot Reviewed-by: Ian Rogers Cc: Don Zickus Cc: Ian Rogers Assisted-by: Claude:claude-opus-4.6 Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/cpumap.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c index dc5c5e6fc502d5..9a9759df3e70f9 100644 --- a/tools/perf/util/cpumap.c +++ b/tools/perf/util/cpumap.c @@ -280,6 +280,12 @@ static int get_max_num(char *path, int *max) buf[num] = '\0'; + /* empty file — nothing to parse */ + if (num == 0) { + err = -1; + goto out; + } + /* start on the right, to find highest node num */ while (--num) { if ((buf[num] == ',') || (buf[num] == '-')) { -- 2.53.0