From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CE0E3C10AB; Tue, 21 Jul 2026 22:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673994; cv=none; b=sEp7h2JxG89Fqse1eT5tRH4Oa8x9bIundSFpWs9hxCWyodqkIfqmu5u2q/5cB0/JA2MdR9/bpzGiyTaljDxHgTpWlmFWQLN4H1TXD0HeJNJy3q0JsmvOz/JjkUuLkydG59aoHdWTneclBv36tYRMBf9kH17iGth/qfGqPTuUusA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673994; c=relaxed/simple; bh=aATNWJupBOuUSvrmKxdVfc8q6vDmIEaGlxim+SPA13M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HuhT6onKrfD4UOSpVObZqSPioadXyhHHuiOk4FlzR1zR1l9p2yvMgWopdeM8ZqBE31uOcrx2zOzuNqzqde980GItvsuAg143/YoEZPA8E8FyeoE5oy301M8MQdGEVaikvoQEWSTaz1kKVlBelFxG6yCH/EWeJbVX0hFpZifSFos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lAppZPew; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lAppZPew" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2A171F000E9; Tue, 21 Jul 2026 22:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673993; bh=6ThVrZEaRZMaEViB4Yq2vegmDPyLFrcrp1laXnd4iP8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lAppZPewa9Px9c9yz4QbBzZllCu/zj9ONSb/DGc04zm+iEZjqi2OzLG+/5XlzhkUg D6KvLBiMzv2ceg5G0mkRHgnV4/xFMZi/aZhypvs270C4+qxJ2kUGcphU9s9AFGPskh r9OavailiZSDCPpdgn9odquV5Pz3WnOW9xNfX5eY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.10 374/699] gpio: mvebu: fail probe if gpiochip registration fails Date: Tue, 21 Jul 2026 17:22:13 +0200 Message-ID: <20260721152404.129902669@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou [ Upstream commit 479e91fc92416a4d54d2b3150aa1e4550d9cc759 ] mvebu_gpio_probe() registers the GPIO chip with devm_gpiochip_add_data() but ignores the return value. If registration fails, probe continues and leaves later code operating on a GPIO chip that was never published to gpiolib. Return the registration error so the device fails probe cleanly. Fixes: fefe7b092345 ("gpio: introduce gpio-mvebu driver for Marvell SoCs") Signed-off-by: Pengpeng Hou Link: https://patch.msgid.link/20260624131645.86884-1-pengpeng@iscas.ac.cn Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-mvebu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 2ab34a8e6273df..0f8b042d5369f2 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1193,7 +1193,10 @@ static int mvebu_gpio_probe(struct platform_device *pdev) BUG(); } - devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip); + err = devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip); + if (err) + return dev_err_probe(&pdev->dev, err, + "failed to register gpiochip\n"); /* Some MVEBU SoCs have simple PWM support for GPIO lines */ if (IS_ENABLED(CONFIG_PWM)) { -- 2.53.0