From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A6993C73F6; Tue, 21 Jul 2026 22:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674058; cv=none; b=BGxR6024NQMWFMFqIB+ykeI4hnzexx1EmEFlNr/zAuhntu2y9V7a2anljzHIjFL6B+PBifCCtmeQKVPCUBs/7Rk1+3x3d5uUOuprAStCreyFFoYOGei7/3C1AMcalpdXum3oa5XUNK1i4L3+PdRmGyLiUU4rDKi0xLQkm2LCMKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674058; c=relaxed/simple; bh=8gpxP3W1NhLQNizil9qBuWnKs2n+qiMXIjbvXeHykac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kTJcWW5A/ko6uGrXeQ19rxsVIEJKIT1DfjFtEUhHC/jdRGVo3jEIYQl1F9sthjkV06YyKGXW7XoxBJPZIXW2hvy+fjm3Dpnmu0CJBReT+mZLxU2lvFA9tDuiThZOoN0VOI9RtdDEpqUh0EITaJkGhCwwGUTqFvbucMjh2zmrykk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GsovtnOJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GsovtnOJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ACB31F00A3A; Tue, 21 Jul 2026 22:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674056; bh=Vylfs2i7/cjmiXZie4REVeA8WHrne8tFZ46mZjHL220=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GsovtnOJOmIoY+6QmcYlXvS7WKC6ME2AUPM3/AQK3raDAD40aMEN7/FMACvVJyKhL RrqwTIxT711AyMz28YS1iMJkU5zMRnFSGdBcze1JHv+4zAcUwpRl5tzSK1k9vIri09 0/bKZD/5LJlLGYmaci4xqt8DXEbZ4za/cr20b6eo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shigeru Yoshida , Jamie Bainbridge , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 396/699] qede: fix off-by-one in BD ring consumption on build_skb failure Date: Tue, 21 Jul 2026 17:22:35 +0200 Message-ID: <20260721152404.629862777@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shigeru Yoshida [ Upstream commit a0a558ca7e75b49e71f8c545c30e8c005e6e4e2f ] qede_rx_build_skb() and qede_tpa_rx_build_skb() do not check for a NULL return from qede_build_skb(). When it returns NULL under memory pressure, the functions still consume a BD from the ring before returning NULL. The callers then recycle additional BDs, resulting in one extra BD being consumed (off-by-one). This desynchronizes the BD ring, which can corrupt DMA page reference counts and lead to SLUB freelist corruption. Commit 4e910dbe3650 ("qede: confirm skb is allocated before using") added a NULL check inside qede_build_skb() to prevent a NULL pointer dereference, but did not address the missing NULL checks in the callers, making this off-by-one reachable. Fix this by adding NULL checks for the return value of qede_build_skb() in both qede_rx_build_skb() and qede_tpa_rx_build_skb(), returning NULL immediately before any BD ring manipulation. Fixes: 8a8633978b84 ("qede: Add build_skb() support.") Signed-off-by: Shigeru Yoshida Reviewed-by: Jamie Bainbridge Link: https://patch.msgid.link/20260630164623.3152625-1-syoshida@redhat.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c b/drivers/net/ethernet/qlogic/qede/qede_fp.c index a632de208a7dc6..02b866a49633c0 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c @@ -770,6 +770,9 @@ qede_tpa_rx_build_skb(struct qede_dev *edev, struct sk_buff *skb; skb = qede_build_skb(rxq, bd, len, pad); + if (unlikely(!skb)) + return NULL; + bd->page_offset += rxq->rx_buf_seg_size; if (bd->page_offset == PAGE_SIZE) { @@ -817,6 +820,8 @@ qede_rx_build_skb(struct qede_dev *edev, } skb = qede_build_skb(rxq, bd, len, pad); + if (unlikely(!skb)) + return NULL; if (unlikely(qede_realloc_rx_buffer(rxq, bd))) { /* Incr page ref count to reuse on allocation failure so -- 2.53.0