From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FCEE3DDB03; Tue, 21 Jul 2026 22:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674145; cv=none; b=YFQlcK8LqeX+1QAHUbhhcErMUydlg3TSx05QWHkPvU20EDx4GdTJmKjrulw18gaDXEIqObfXggqTiDf0948eLlR/x+twLTH3mDM4XsaM4Xb5KLLeJFwV7sYuV12lXt5nTVl6EPaRqRpDFwLq0qAlbKcJC9ecTrufO7yE8rKoe/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674145; c=relaxed/simple; bh=l/TcU10I/4AkvyDi7IJ3QWioy1EP7fgvXLNDQLydhRg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IaphePRV9E2gs+DNztNgBpiEURVpoezluAq51rxTJIaPlmgyIPHcYc5VQN7FBhz5TLyM4232ofpSkjCWaNVz8quGw5omXaAQ9D/AQAyCbQFwmy/2EyVZp9QiBGUE8L7EQV44qPeDgDCvZwNjzClrol2oaaBKD3xIpV79LEOaMeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=p59HbqV0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="p59HbqV0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5B781F000E9; Tue, 21 Jul 2026 22:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674144; bh=dzSYdmONA9HqEtKhLeskhml+KNU4ad9TzoMEj6ICfKA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=p59HbqV0Y+EX1okPsXaMZXs04Yzet1oKIupK4GHkHBnx4VXhs0tv8V5hfUjOzlQKj kWoQEwL7phji2hYCddUQ8qHBRDw84tPw38LpRTvrhGkv0rfz5bKKwEm368f2QvxPqK Vj/BhF0LY+a1I/iMRVnH1w2nCsligi3qzixaI1CI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Michael Bommarito , Simon Horman , Jakub Kicinski Subject: [PATCH 5.10 430/699] net: qrtr: fix 32-bit integer overflow in qrtr_endpoint_post() Date: Tue, 21 Jul 2026 17:23:09 +0200 Message-ID: <20260721152405.391652292@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michael Bommarito commit 20054869770c7df060c5ecee3e8bbf9029c47191 upstream. qrtr_endpoint_post() validates an incoming packet with if (!size || len != ALIGN(size, 4) + hdrlen) goto err; where size comes from the wire. On 32-bit, size_t is 32 bits and ALIGN(size, 4) wraps to 0 for size >= 0xfffffffd, so the check passes and skb_put_data(skb, data + hdrlen, size) writes past the hdrlen-sized skb and oopses the kernel. 64-bit is unaffected. This is the 32-bit residual of ad9d24c9429e2 ("net: qrtr: fix OOB Read in qrtr_endpoint_post"), which fixed only the 64-bit case. Reject any size that cannot fit the buffer before the ALIGN. Fixes: ad9d24c9429e2 ("net: qrtr: fix OOB Read in qrtr_endpoint_post") Cc: stable@vger.kernel.org Signed-off-by: Michael Bommarito Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260611125455.2352279-1-michael.bommarito@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/qrtr/af_qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/qrtr/af_qrtr.c +++ b/net/qrtr/af_qrtr.c @@ -490,7 +490,7 @@ int qrtr_endpoint_post(struct qrtr_endpo goto err; } - if (!size || len != ALIGN(size, 4) + hdrlen) + if (!size || size > len || len != ALIGN(size, 4) + hdrlen) goto err; if ((cb->type == QRTR_TYPE_NEW_SERVER ||