From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EFC8430CE3; Tue, 21 Jul 2026 22:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674314; cv=none; b=TzMDKPCubl5rR0qathoNOOTAhd240dG5nrjxIdgnOz2rY6n4D8pbgtV8nj0eiSsv+VCAiSynQ4U6P3qnJU+DsjgQ+W2seuoa2iC2uj3HUQo7iT3MGby0oyHfip95go6YS5NZcNRiUVLWN8ZGRr0OeWLNcAtX9OLnqi8OSpztupI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674314; c=relaxed/simple; bh=SfRj54LLEGl3f9saY4b7Ws3c7wqXY2kcddbtTbWsdz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uhGtlcY9jAojIDXj3VWmNDHaOPposlHUvobfgnqqRt7pJhdvoAUADE13VJhdHx+TGlndxFq/aJJeJdM7HXf24rscLkXJHcpkb2mxtD7L5RgaFOpIrQdasx4QHgV4jyg04ePvjN26BRJInbE+YcIdwH/kR0bo/aWkQdQUGWtFXHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wWZiVHQ0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wWZiVHQ0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84D081F000E9; Tue, 21 Jul 2026 22:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674313; bh=lcGKFZVtAgzGo+XUIh9msAsiVJCPXs/r/U+FZV29ieQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wWZiVHQ0KicVpTlFiF5kbkIg91N1hdgT4SH7VZQTQTtJLiMsAM5OHkaYDzstQiQt8 5FjGw3Xm4zaG6O+6rnpwOyAi41L9yp51e4aQ9O6RiIgVbjEy1wlERjYrGH83JFZcSf sso30D+xg/LXtvcz497VFeraezRD38+dsvXLv19c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Roman Vivchar , AngeloGioacchino Del Regno , Andi Shyti Subject: [PATCH 5.10 492/699] i2c: mediatek: fix WRRD for SoCs without auto_restart option Date: Tue, 21 Jul 2026 17:24:11 +0200 Message-ID: <20260721152406.795689522@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Roman Vivchar commit deb35336b5bfed5db9231b5348bc1514db930797 upstream. MediaTek mt65xx family SoCs have no auto restart, however, they still support the WRRD mode in the hardware. Because auto_restart is set to 0, the WRRD mode will be never enabled, leading to read errors. Fix this by removing auto_restart check from the WRRD enable path. Fixes: b49218365280 ("i2c: mediatek: fix potential incorrect use of I2C_MASTER_WRRD") Signed-off-by: Roman Vivchar Cc: # v6.18+ Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20260709-6572-6595-i2c-v2-1-b2fb8510d1d3@protonmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-mt65xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/i2c/busses/i2c-mt65xx.c +++ b/drivers/i2c/busses/i2c-mt65xx.c @@ -1075,7 +1075,7 @@ static int mtk_i2c_transfer(struct i2c_a i2c->auto_restart = i2c->dev_comp->auto_restart; /* checking if we can skip restart and optimize using WRRD mode */ - if (i2c->auto_restart && num == 2) { + if (num == 2) { if (!(msgs[0].flags & I2C_M_RD) && (msgs[1].flags & I2C_M_RD) && msgs[0].addr == msgs[1].addr) { i2c->auto_restart = 0;