From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CDE03E49F5; Tue, 21 Jul 2026 22:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674343; cv=none; b=i9RuATE1iwJWLaLRcgc6ZelrOKz8qBDd4jj8kEg0Eu7m5uVgff+p767/XLGRYdkj4nvX+mQFAmGrG6gkJ+J0yeol5IoXZOWAWIy7tO4vfG2Xye49dGSGN9QPLi23PQca1BSoCjqWQf3bi+syMdNOXVALvaPYJcgzFFuKEWdHHu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674343; c=relaxed/simple; bh=/srt9/3rMNss00/T0PdzmaPZOs/kM9vV+D4Zf1HJKV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o64+vk8GwGOdBoNX+j3xj1HSpdJjS1fwNbRAZgeGtThNKt19yoaa9pT/LWHXJS8InG1OLGnMrs/LEy/pk8F6yfdWUnGVb0cp8LIbdLEC7Tg42FxOp3oI0qsBs9e6fWs9RWYZr7gAEFvsjgCTtsKegex8V1o0qICRJJLKDPtBR+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=12HHW2r5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="12HHW2r5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A0191F000E9; Tue, 21 Jul 2026 22:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674342; bh=rLcGLFuyzoQJ93Nd34u8vnh/xTW2DVq2GjT6wkV2P0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=12HHW2r5f8EY2K4LN0TJYhPhwTOEc9OIM2avMrAh0fWOR1CVvvXMt/hd6ERM+G1ax g3mKKSUB3PqlZbStecMxKJvCGPxoxeKEcm9fpjWBw5YP9ePZph2x9i0FMxv9HUZzSX +FN25zSO2pJiVODAsTKE0repd3pjnquqJxJmvNQ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Genjian Zhang , Mikulas Patocka Subject: [PATCH 5.10 506/699] dm thin metadata: fix superblock refcount leak on snapshot shadow failure Date: Tue, 21 Jul 2026 17:24:25 +0200 Message-ID: <20260721152407.109062082@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Genjian Zhang commit 4b22d0801fadfcae2e106e6ba32e49439c7c7ebf upstream. __reserve_metadata_snap() increments THIN_SUPERBLOCK_LOCATION in the metadata space map before shadowing it. When dm_tm_shadow_block() fails, a reference is leaked in the metadata space map. Fix by adding the missing dm_sm_dec_block(). Signed-off-by: Genjian Zhang Signed-off-by: Mikulas Patocka Fixes: cc8394d86f04 ("dm thin: provide userspace access to pool metadata") Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-thin-metadata.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/md/dm-thin-metadata.c +++ b/drivers/md/dm-thin-metadata.c @@ -1308,8 +1308,10 @@ static int __reserve_metadata_snap(struc dm_sm_inc_block(pmd->metadata_sm, THIN_SUPERBLOCK_LOCATION); r = dm_tm_shadow_block(pmd->tm, THIN_SUPERBLOCK_LOCATION, &sb_validator, ©, &inc); - if (r) + if (r) { + dm_sm_dec_block(pmd->metadata_sm, THIN_SUPERBLOCK_LOCATION); return r; + } BUG_ON(!inc);