From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB037415F0C; Tue, 21 Jul 2026 22:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674411; cv=none; b=dGXJGHoHQftKSpCSPmmRtjllmDtCf5gwmx0aujB1oVZM3MWxscvwrTtH7qTgrO/tL5JZjyAckkQtlBE59wi6Hd2QBrSy+dUJJfvmvqHB8Rhwdu3aYrXqBNWFRcOFr5C/E3rMsv1Tp7ZtTno9qeNbEbEDn2iCSZ97myiBFZJ0vF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674411; c=relaxed/simple; bh=E9HYyaSfa2xoe32tnohLuLohO1pn+zvxLR6un4qRsdA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W2r+IxhGjgSiu1h5NfY4PoDIDkBBwBPie8zyJ2pGKD4W+cr0kmFXC87aJh2xoLxvSgGFbbjcL/DZaaWyFvtEeXIkdjTTq5C+g9rxh4sO97gh0FJjfnu9SvmKRyjjGmKWq6hfjJcYdiTOP63InaaVt520rkYs5qCHTB2kJ/DVxrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K5CWx5MU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K5CWx5MU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D6431F000E9; Tue, 21 Jul 2026 22:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674410; bh=OFhW4ShupgLUMBJz6ecnnNtGFrmmd4s06D7CS2rNa+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=K5CWx5MUlVI/KXP4purBNnhkvJjgncelgknGDV1ivRRKqsQVfUJ+tBwxVmpmr2IaL NpQb8/c4PlZ8vNOtY8Qg5HdKgSfW5IHHkmRfLrPfRUaXN0KrYPSQ7/xys8LmlfNcv1 h5qspmwc9/ffkWEaTRs5/v0FE2LSbC+/7wd0QdWo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiao Liang , Maoyi Xie , Kuniyuki Iwashima , Jakub Kicinski Subject: [PATCH 5.10 530/699] net: ip6_vti: require CAP_NET_ADMIN in the device netns for changelink Date: Tue, 21 Jul 2026 17:24:49 +0200 Message-ID: <20260721152407.653203931@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit e2ac3b242c37dff323a964962e43854f4b1a2b79 upstream. vti6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate vti6_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 61220ab34948 ("vti6: Enable namespace changing") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260612085941.3158249-7-maoyixie.tju@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv6/ip6_vti.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ipv6/ip6_vti.c +++ b/net/ipv6/ip6_vti.c @@ -1048,6 +1048,9 @@ static int vti6_changelink(struct net_de struct __ip6_tnl_parm p; struct vti6_net *ip6n; + if (!rtnl_dev_link_net_capable(dev, net)) + return -EPERM; + ip6n = net_generic(net, vti6_net_id); if (dev == ip6n->fb_tnl_dev) return -EINVAL;