From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2F143C7AE; Tue, 21 Jul 2026 22:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674502; cv=none; b=QWOnBqRLo29HVpb0R2rxNHGDhLQuY3byhsJqBl1uClacO4HG3txmr9kz67pLqErFmaDT+0EPqZpxFH7e2SmZ0AllKdxtBbHp9YkjoRIcYLvEY2jf08Qd4pNHr12je7H3WDh75eItPxN9SJv8igBw5iD0caGhg6NtqhcAx4Cp+Ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674502; c=relaxed/simple; bh=PmRha5RuDEJloiNsugCZ4N3iYA8kPon0oGJqNuBx/pA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cV8nCmP+OopkAATuZwJQRrHkXoZP2Q1jHJlbEWf78cz75okWv70aewNZI3tzE2NgH9+FG2fbnjztIx+Vt909n2I4xH2PQREJ45pDT9xhgs1QjIbIF+hoTWBTJO0Bg6Qrryj8bPbAqlt9oZ55Ps8k9jwdGI9PUzyr40UmtZRO1Ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=M8ie0Mrw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="M8ie0Mrw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EC351F000E9; Tue, 21 Jul 2026 22:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674500; bh=KVSYlXaOuj8PsO0NbI0nAsbsHFBwOFuUzeCq+8+2+3A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=M8ie0MrwboFRNz2k8MCQw9Y/xd+ysGvfHfDTQtz06VX219IyRkSzTsEX8mTQiFIOJ qWPNTHkZxwPVICSSTCb5pY0ZMwzR6UAHyehDtpMkjcshJnagYZDbUXpMdhBeCx4NCT lkte4sezvbDzSXoDxLuZIQDLNgm/SC8RxlwVMsuY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maoyi Xie , Ulf Hansson Subject: [PATCH 5.10 565/699] memstick: ms_block: reject a card that reports too many blocks Date: Tue, 21 Jul 2026 17:25:24 +0200 Message-ID: <20260721152408.454398913@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit 718178f524b98bc920d74bc771aed823c8b81425 upstream. msb_ftl_initialize() computes the zone count from the card block count with no bound: msb->zone_count = msb->block_count / MS_BLOCKS_IN_ZONE; ... for (i = 0; i < msb->zone_count; i++) msb->free_block_count[i] = MS_BLOCKS_IN_ZONE; msb->block_count is a card value. msb_read_boot_blocks() reads number_of_blocks from the card boot page and byte swaps it. free_block_count is a fixed int[MS_MAX_ZONES]. MS_MAX_ZONES is 16, so the valid indices are 0 to 15. The init loop above indexes it by zone_count. msb_mark_block_used() and msb_mark_block_unused() index it by pba / MS_BLOCKS_IN_ZONE, for pba up to block_count - 1. A card may report up to 65535 blocks. A block_count above 8192 (MS_MAX_ZONES * MS_BLOCKS_IN_ZONE) lets the pba index reach 16. That writes past free_block_count[] and corrupts struct msb_data. A larger count runs the init loop past the end too. A real Memory Stick has at most 16 zones. So it has at most 8192 blocks. msb_ftl_initialize() now rejects a card that reports more than MS_MAX_ZONES * MS_BLOCKS_IN_ZONE blocks. Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/memstick/core/ms_block.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -1333,6 +1333,10 @@ static int msb_ftl_initialize(struct msb return 0; msb->zone_count = msb->block_count / MS_BLOCKS_IN_ZONE; + if (msb->block_count > MS_MAX_ZONES * MS_BLOCKS_IN_ZONE) { + pr_err("Too many blocks: %d\n", msb->block_count); + return -EINVAL; + } msb->logical_block_count = msb->zone_count * 496 - 2; msb->used_blocks_bitmap = bitmap_zalloc(msb->block_count, GFP_KERNEL);