From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68BCE382385; Tue, 21 Jul 2026 22:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674614; cv=none; b=Xl8+17vmO6FkfeUiFz7qBVZ8tY7ubRx6QVNZ/38oP89lA/wsHh5SQb+Q39eINOcNUItJoYTjWSv5jKbQxOzBTE5RKESH/wqC3CNLzPXuKhlstEdv7Nym4tu7QX1pOPr26RKRMCiEU3yyNjTVZdmKzSVYZdFcByw/s9MEy+MB8MQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674614; c=relaxed/simple; bh=wMzKysCSJOX8E2uMKrHeHw9C3HIryaYLkqkgkXyY538=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NPP1Wq2F6tb+SGF4n/HQi2vPaTkWJT7vWw4ZBuFmMgrVVceYKO9xzHl1a/0ZpMqMyg8isw5aAxSYWuU4M3WAHBL9RE62y8fzZSzoDvrMm/LK66KDObQhPV33lIbDI/5ZfNB1vgZlsfXezSwbfDNYo51/rqWL63j93xlcxYnCH9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NkglZ7ay; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NkglZ7ay" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5B121F000E9; Tue, 21 Jul 2026 22:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674613; bh=0kCnMHXTVQ+KbxTdlLS6weTTQX85TRZIdNIOmb9LXEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NkglZ7ay5IF8HRbFvDve3nONyS3Ym2Tj2pa4M+u5WpWjoagga/epcVOvk7sBf8S7+ c/lIO3BvrTWp0Y/SzooQfLbtnfyJjzhn3wHUYD/hdVydNGWd4jZq+8xhCI76idJX9r Vgaxzz2P5XOkhgYnwDXW4cs5uiFh/BviOqrOkAhc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Arnd Bergmann , Andy Shevchenko , Sakari Ailus , Sasha Levin Subject: [PATCH 5.10 607/699] staging: media: atomisp: reduce load_primary_binaries() stack usage Date: Tue, 21 Jul 2026 17:26:06 +0200 Message-ID: <20260721152409.431148933@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann [ Upstream commit f4d51e55dd47ef467fbe37d8575e20eee41b092d ] The load_primary_binaries() function is overly complex and has som large variables on the stack, which can cause warnings depending on CONFIG_FRAME_WARN setting: drivers/staging/media/atomisp/pci/sh_css.c: In function 'load_primary_binaries': drivers/staging/media/atomisp/pci/sh_css.c:5260:1: error: the frame size of 1560 bytes is larger than 1536 bytes [-Werror=frame-larger-than=] Half of the stack usage is for the prim_descr[] array, but only one member of the array is used at any given time. Reduce the stack usage by turning the array into a single structure. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann Reviewed-by: Andy Shevchenko Signed-off-by: Sakari Ailus Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/pci/sh_css.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -5870,7 +5870,6 @@ static int load_primary_binaries( struct ia_css_capture_settings *mycs; unsigned int i; bool need_extra_yuv_scaler = false; - struct ia_css_binary_descr prim_descr[MAX_NUM_PRIMARY_STAGES]; IA_CSS_ENTER_PRIVATE(""); assert(pipe); @@ -6058,15 +6057,16 @@ static int load_primary_binaries( /* Primary */ for (i = 0; i < mycs->num_primary_stage; i++) { + struct ia_css_binary_descr prim_descr; struct ia_css_frame_info *local_vf_info = NULL; if (pipe->enable_viewfinder[IA_CSS_PIPE_OUTPUT_STAGE_0] && (i == mycs->num_primary_stage - 1)) local_vf_info = &vf_info; - ia_css_pipe_get_primary_binarydesc(pipe, &prim_descr[i], + ia_css_pipe_get_primary_binarydesc(pipe, &prim_descr, &prim_in_info, &prim_out_info, local_vf_info, i); - err = ia_css_binary_find(&prim_descr[i], &mycs->primary_binary[i]); + err = ia_css_binary_find(&prim_descr, &mycs->primary_binary[i]); if (err) { IA_CSS_LEAVE_ERR_PRIVATE(err); return err;