From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 729FB370AFB; Tue, 21 Jul 2026 21:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671189; cv=none; b=XXR3qVKzHu1HEXIUQn+PWQFxmi4tuoCcWumLV4ufx0FT/0q5/Fdhu8CBFhy0pKYrxLyOjpYaqgiB9cOHSKaJWM0i8B5pQOoNSe6KR+Zq8i22CnBtxxDNx5c9fJtGznKRkLm+pXsfGFRrrB29VL8mU4x12RhJVOt7KIPMst2tuXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671189; c=relaxed/simple; bh=LBUTrRpB/KtssVVp0lEdIlUXRM0X8/R6VNMrFyy6/OA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g6miQ4eXXRYW9H2LLsPJOOz9vI6uBRhotlO/RdYosK4mRdyg23wOzGW+OMWz1gjzZ2jkB/GBUCPSRL4Hec/fmOZAJd+cqDEqu3MILezsIgXPlNemsnxFoiYMexDd9B17vB/eDDeY2hj8gACap1F4qADfxCq+CDI8uFWj1ognVO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OUXnBCLM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OUXnBCLM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D82C91F000E9; Tue, 21 Jul 2026 21:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784671188; bh=2u4FqgKYHi2eI2ajcV3aAshG+h3PiC+q0Q5cPgy2c3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OUXnBCLMu21ETPdzErQior4gMXGdWT943+0Fawgv3RYuTYnDBrBQrRdcEXDM8DIP2 OKGhlbCnOVZXtT8oIa7fTIWycs0SJWfRkNnqqiP2vEihpcrD74a0a67Zb7qok4PI1h OQCniI5xeElxYW7ko33Mla+0uH8zNheKTb9/JL/c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Badhri Jagan Sridharan , RD Babiera , Heikki Krogerus Subject: [PATCH 5.15 152/843] usb: typec: tcpm: Validate SVID index in svdm_consume_modes() Date: Tue, 21 Jul 2026 17:16:27 +0200 Message-ID: <20260721152409.433765128@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Badhri Jagan Sridharan commit 7b681dd5fbf60b24a13c14661e5b7735759fb491 upstream. In svdm_consume_modes(), the SVID value is read from pmdata->svids using pmdata->svid_index as an array index without bounds validation: paltmode->svid = pmdata->svids[pmdata->svid_index]; If pmdata->svid_index is driven beyond SVID_DISCOVERY_MAX (16), it results in an out-of-bounds read of the pmdata->svids array. Because pd_mode_data is embedded inside struct tcpm_port, indexing past svids reads into adjacent fields. In particular: - At index 16, it reads the altmodes count. - At index 18 and beyond, it reads into altmode_desc[], which contains partner-supplied SVDM Discovery Modes VDOs. By injecting a chosen SVID into altmode_desc[0].vdo and driving svid_index to 20, the partner can force paltmode->svid to be loaded with an arbitrary, partner- chosen SVID, which is then registered via typec_partner_register_altmode(). Fix this by validating that pmdata->svid_index is non-negative and strictly less than pmdata->nsvids before accessing the pmdata->svids array inside svdm_consume_modes(). Assisted-by: Antigravity:gemini-3.5-flash Fixes: 4ab8c18d4d67 ("usb: typec: Register a device for every mode") Cc: stable Signed-off-by: Badhri Jagan Sridharan Reviewed-by: RD Babiera Acked-by: Heikki Krogerus Link: https://patch.msgid.link/20260622220803.305750-1-badhri@google.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/tcpm/tcpm.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -1538,6 +1538,11 @@ static void svdm_consume_modes(struct tc return; } + if (pmdata->svid_index < 0 || pmdata->svid_index >= pmdata->nsvids) { + tcpm_log(port, "Invalid SVID index %d", pmdata->svid_index); + return; + } + for (i = 1; i < cnt; i++) { paltmode = &pmdata->altmode_desc[pmdata->altmodes]; memset(paltmode, 0, sizeof(*paltmode));