From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5BA44AB62; Tue, 21 Jul 2026 22:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671383; cv=none; b=qT5jHTpWuNmOLc44jqjQlxeLFUNMtQSizw5nrHtqVpZnVXjWPZCxZrfzsKEVgF7Ka8z8gdMhTMNgRgAdZt1Rix/FRN9yMdJk7UZqy1tgL0y8ddYI806fwHhLCCdpxahhT+jpnA97QxAxjvtwNuGoa0EQNQx6Sjp1XEdy+ic2Yrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671383; c=relaxed/simple; bh=WLuey3zJaR+89e74RbDB7q6pSURjcV5xDj7X5qY16tw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b9VcMyf+3bKbDDjQJ1afhFQuOy5uAIL0/zk97Nb2SX6b+XSMjI0gaCuKdfAs68enlMLlx74iS45nnrbn6BBMqaubMpQ+Yr2GmYMcYwL5bvPWrNDYvve8NHGp9rN4RhRRH1+XNG/5asr8OI8Mte276TMcm4rE+EvjZhCeae1hW5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nqv3qxcF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nqv3qxcF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B31371F000E9; Tue, 21 Jul 2026 22:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784671382; bh=YFM+NGpQMezgCjmUFyy+NaLfirtJSO4uwUt30BmcuWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nqv3qxcFW5wJlmurtiz/t4Wx8V4r8zuq7L1V85ibHT7DUeaPmclxOzdqKLTDbjbVP g2MB2dHFh7txwcgVR9XnvldmvHFBRmbQrzypFJxiG5mls8to8+7SCz14hhLOhbD/UD YWQicwKvtdlOu7x2H46LgQIshCU/ZZj82nj/IQ8I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuho Choi , Alex Deucher , Sasha Levin Subject: [PATCH 5.15 218/843] drm/radeon: fix memory leak in radeon_ring_restore() on lock failure Date: Tue, 21 Jul 2026 17:17:33 +0200 Message-ID: <20260721152410.922486702@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuho Choi [ Upstream commit 82f1d6042611d45b8b9de423bbcb4e0ced9ec62b ] radeon_ring_restore() takes ownership of the data buffer allocated by radeon_ring_backup(). The caller (radeon_gpu_reset()) only frees it in the non-restore branch; in the restore branch it relies on radeon_ring_restore() to free it. If radeon_ring_lock() fails, the function returned early without calling kvfree(data), leaking the ring backup buffer on every GPU reset that fails at the lock stage. During repeated GPU resets this causes cumulative kernel memory exhaustion. Free data before returning the error. Fixes: 55d7c22192be ("drm/radeon: implement ring saving on reset v4") Signed-off-by: Yuho Choi Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/radeon/radeon_ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c index 7e207276df374f..e009ee1559c8ed 100644 --- a/drivers/gpu/drm/radeon/radeon_ring.c +++ b/drivers/gpu/drm/radeon/radeon_ring.c @@ -354,8 +354,10 @@ int radeon_ring_restore(struct radeon_device *rdev, struct radeon_ring *ring, /* restore the saved ring content */ r = radeon_ring_lock(rdev, ring, size); - if (r) + if (r) { + kvfree(data); return r; + } for (i = 0; i < size; ++i) { radeon_ring_write(ring, data[i]); -- 2.53.0