From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A862E3B9D9D; Tue, 21 Jul 2026 22:04:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671449; cv=none; b=hwqFLayMpnO7fwzo7uY2xfKdO/+CLzrePeP6f869CQ/8jdo6emDuaO6dMwKZPtRV9DttYSGzNmZOBDGaQUu+ESVzxnnvQS7R612mBC/VM4OacObXbO/hli6iF1GAWzuL9WKS96LMWES6nh8FOI53Xe7M1FmNk6KV2LWm7GPYDWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671449; c=relaxed/simple; bh=ZSJtPfLN4QfMXIdEm1K1Rf0NQQD77OQUZKS8vuptJeA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BW+S9tre+UgV3TvtAbqQZn6/UuL2XovqJpwr9FH+UiGPYpCuBKCdvCO08cQ+Rd2CspitQ8s3mUZwfEeITCxNerZ7vx+fo2B6B+XJSPf/+s7QaY3BiFztFrxbGVwHkOPoa3FmClJKnFRrJlevHBSz4vsrOBHE9Gqwoc4AECY/FsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Oa9XQA9n; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Oa9XQA9n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19D251F000E9; Tue, 21 Jul 2026 22:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784671448; bh=txoPEtsX7ck8Mhn28Ev438Fl8UjgzdwvDm6/Z4B1jko=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Oa9XQA9ni2X5umFXCm37uXs9Vs1oE9Z5kZN9cQqGriD3etjOlDYMUpc2InZ5cfZK/ N/jlKrFs2Qe8PzvPwWIpYoHmC140ZcN6kBA3cObR6z7Z0UPxTumI7plntRjmSZaZVN l+qRnQwpb+Z/QIC40JBVK8xxAIL8wR95XGNvdLgE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nicolas Dufresne , =?UTF-8?q?Sven=20P=C3=BCschel?= , Hans Verkuil , Sasha Levin Subject: [PATCH 5.15 249/843] media: rockchip: rga: fix too small buffer size Date: Tue, 21 Jul 2026 17:18:04 +0200 Message-ID: <20260721152411.621385783@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sven Püschel [ Upstream commit 65017e26c065d1240b0512c15867ef1128034fd8 ] Fix the command buffer size being only a quarter of the actual size. The RGA_CMDBUF_SIZE macro was potentially intended to specify the length of the cmdbuf u32 array pointer. But as it's used to specify the size of the allocation, which is counted in bytes. Therefore adjust the macro size to bytes as it better matches the variable name and adjust it's users accordingly. As the command buffer is relatively small, it probably didn't caused an issue due to being smaller than a single page. Fixes: f7e7b48e6d79 ("[media] rockchip/rga: v4l2 m2m support") Reviewed-by: Nicolas Dufresne Signed-off-by: Sven Püschel Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/rockchip/rga/rga-hw.c | 2 +- drivers/media/platform/rockchip/rga/rga-hw.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c index aaa96f256356b0..bdfb9bc3eb3f6d 100644 --- a/drivers/media/platform/rockchip/rga/rga-hw.c +++ b/drivers/media/platform/rockchip/rga/rga-hw.c @@ -379,7 +379,7 @@ static void rga_cmd_set(struct rga_ctx *ctx) { struct rockchip_rga *rga = ctx->rga; - memset(rga->cmdbuf_virt, 0, RGA_CMDBUF_SIZE * 4); + memset(rga->cmdbuf_virt, 0, RGA_CMDBUF_SIZE); rga_cmd_set_src_addr(ctx, rga->src_mmu_pages); /* diff --git a/drivers/media/platform/rockchip/rga/rga-hw.h b/drivers/media/platform/rockchip/rga/rga-hw.h index e8917e5630a48d..03990fd30f158c 100644 --- a/drivers/media/platform/rockchip/rga/rga-hw.h +++ b/drivers/media/platform/rockchip/rga/rga-hw.h @@ -6,7 +6,7 @@ #ifndef __RGA_HW_H__ #define __RGA_HW_H__ -#define RGA_CMDBUF_SIZE 0x20 +#define RGA_CMDBUF_SIZE 0x80 /* Hardware limits */ #define MAX_WIDTH 8192 -- 2.53.0