From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27C3843E079; Tue, 21 Jul 2026 22:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671455; cv=none; b=YfoZLxMik9ckA7m7bkPHjttmJED6X88edWkxm7R8vOR8ZrWm5Qb+TES//36gwo3IpKLyY7WnxoKnlS4iz2pyXI51K6GrV8fqYfwwMMH4Q7wV8RR1o1WdRP5/QkqmyEfNQgiglNbpTbvqWVvNjhT1IDlE+dCS21RXjX2JvPiz+YE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671455; c=relaxed/simple; bh=CMh2k3YG9AH+wJohvdJmGOQLNuX81wfgWPlFSi758DQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HtPz9y/SDtTnsDIF9UdnSX72tGGTBxboKNjWHAgTZJcRjdtIpIY1FQP6NGdPdKudMSoL2VBUeVRHj6ORKfTINePz2mu5sqXFjo6hfNbn5jOfSzk/jFIurEoQ9ssUtgirsHvb6BcTEGlTtjAJx4UcDDXPvzAR7U/vtkZWJeZVb4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YawYoPQT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YawYoPQT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5657E1F000E9; Tue, 21 Jul 2026 22:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784671453; bh=elp6BDblxoMcReoNt6NX71JjiTURq3Wy3G7GDhfdXas=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YawYoPQTKjqv8ajsyxQAfdm+MhjdjtVWBmsPUuFBCnzdr3t5N7+WlbQM/hMLkXW1+ U73TcZiVU2MIeYmPfvUg66EHRKkaCdoaJ60q54C572Z/TjRESKTSdDJpltBfLEaDzh PPvYOoT1ZSBSY5nV8x4PLKIiMAqDAsuCH/0lm/og= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stepan Ionichev , Sasha Levin Subject: [PATCH 5.15 251/843] device property: fix fwnode reference leak in fwnode_graph_get_endpoint_by_id() Date: Tue, 21 Jul 2026 17:18:06 +0200 Message-ID: <20260721152411.668966543@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stepan Ionichev [ Upstream commit 9582485a65eacfd7245ec7f0a9d7e2c34749d669 ] When called with FWNODE_GRAPH_ENDPOINT_NEXT, the function walks every endpoint under the requested port and, for any endpoint whose ID is greater than or equal to the requested one, may store a fwnode reference in best_ep via fwnode_handle_get(). If a later iteration finds an exact-ID match, the function returns that endpoint directly without dropping the reference held by best_ep, leaking it. Drop the saved candidate before returning the exact-match endpoint. This affects callers that use FWNODE_GRAPH_ENDPOINT_NEXT to ask for the next endpoint with ID >= the requested one (used by a number of media drivers, e.g. imx7/8, sun6i CSI, omap3isp, xilinx-csi2, stm32-csi). Each leak retains a fwnode reference until reboot/unbind. Fixes: 0fcc2bdc8aff ("device property: Add fwnode_graph_get_endpoint_by_id()") Signed-off-by: Stepan Ionichev Link: https://patch.msgid.link/20260514171455.27271-1-sozdayvek@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/base/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/property.c b/drivers/base/property.c index b6984a1a6210eb..e490166261d9ab 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -1290,8 +1290,10 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode, if (fwnode_ep.port != port) continue; - if (fwnode_ep.id == endpoint) + if (fwnode_ep.id == endpoint) { + fwnode_handle_put(best_ep); return ep; + } if (!endpoint_next) continue; -- 2.53.0