From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A2F4407CDA; Tue, 21 Jul 2026 22:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672223; cv=none; b=nMf0BC063REmCViB/CpVBxVD4qIFgIVelFaxBpXOWFJ3t+M5yxlhafbP3EIYWZYZrltWO5jFCAltnDm3yEnc7b97m6+kBN+QtT/DtFqc1X4edSplvtCsvBqxFYybOoqLDIhwwxpJV5wekmz7roHVuVPqzHk9gPJoJLjHQijaBww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672223; c=relaxed/simple; bh=+sjJw5Q6B9IVGcDAqX+1Z54UED8vVtS4wMaz76Fbkns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DwmFhLSPrJQ/Jtf8EhTgFdHJRFAHWh+4hmRN0E+KxfghathjIY7OD2GcQgpyP8NSaQ3rCxWPSVamcplb5i86uWQCeLISSGRB86HdvhoKe0nwsmWVpR7JTMocmVP02UvsmbltWJixzIB7MzjdhZ4C8ALUZO8miFemqiBRmfb0I+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Mg13VQxD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Mg13VQxD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F7101F000E9; Tue, 21 Jul 2026 22:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784672221; bh=K7KA1IvhOUkybAajrUpIwanWDhnUpmPndyNSKLnVDlg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Mg13VQxD4WyXyNgBEPi+h5LgoY3jmb4bWLFk6snt3D99KGD5pea2CUDNdyM3sjPnj hw4BoqG5Ora48MsQ2RIONMPIymKj5MhbIkuBXyyxMS0gu1CPrO0H771wlu+xfefVhn W5hhAplVnv8F7fXfq+0ZRhCaZCasyEml9oxkUuAA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Masami Hiramatsu (Google)" , Sasha Levin Subject: [PATCH 5.15 500/843] tracing/events: Fix to check the simple_tsk_fn creation Date: Tue, 21 Jul 2026 17:22:15 +0200 Message-ID: <20260721152417.279389634@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Masami Hiramatsu (Google) [ Upstream commit cda1fbfc5313bb90daa271d45eea4a8d317a8544 ] Sashiko pointed that this sample code does not correctly handle the failure of thread creation because kthread_run() can return -errno. Check the simple_tsk_fn is correctly initialized (created) or not. Link: https://lore.kernel.org/all/178165817322.269421.3992299509400184196.stgit@devnote2/ Link: https://sashiko.dev/#/patchset/178092865666.163648.10457567771536160909.stgit%40devnote2 Fixes: 9cfe06f8cd5c ("tracing/events: add trace-events-sample") Signed-off-by: Masami Hiramatsu (Google) Signed-off-by: Sasha Levin --- samples/trace_events/trace-events-sample.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/samples/trace_events/trace-events-sample.c b/samples/trace_events/trace-events-sample.c index 1a72b7d95cdc74..2bcae90d85e51f 100644 --- a/samples/trace_events/trace-events-sample.c +++ b/samples/trace_events/trace-events-sample.c @@ -94,6 +94,10 @@ int foo_bar_reg(void) * for consistency sake, we still take the thread_mutex. */ simple_tsk_fn = kthread_run(simple_thread_fn, NULL, "event-sample-fn"); + if (IS_ERR_OR_NULL(simple_tsk_fn)) { + pr_err("Failed to create simple_thread_fn\n"); + simple_tsk_fn = NULL; + } out: mutex_unlock(&thread_mutex); return 0; -- 2.53.0