From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4BE7442FB7; Tue, 21 Jul 2026 22:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672302; cv=none; b=XpL9+E9umt+cKz9WmnkGJOXpK4hOAjZPblX4sE4VUU+Juh/SGXVri1NVMxfnAvaVZAZpRhSXLD9wgJ+eo3H5J6ietKchP+7jelBb1/jygZft5SGnIn3QDIfiV1Fs6d153KmVVXRFdOUIpuKqxNfFa/GRLp1zuecD37rlaWZZcMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672302; c=relaxed/simple; bh=fA1MhPbF2lpwg1qGbimZcnlYUyWUWzV3EgcH5zBdpN4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LFA9wy39545nE4P2PfuuVwlcP8Wanv9mZ5WzpYIVjTmk4AAPRLscR0Azzz02hv2GS5rpJW+9zRR10FuTa0AKNII3s7JC0SzKde+aaUqISkFSGNRUAJrYfinandO0BBx8+lGs+KWkrPjdf7ETKcWWnBmSqWhfoNbrGQKd2qqVTAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NY6H4K/w; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NY6H4K/w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD7B31F000E9; Tue, 21 Jul 2026 22:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784672301; bh=y4+xFK3BqKXjB+sTxPP+ihBYx7JbSFqc9AglS3OFVrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NY6H4K/w0hLtlcEQKS1B6FcWkkXIsYGrdjrHvm3Xxmg+7ke9WL3TcmP4iX3TD6xh9 mlF82yUSWA6uqyhUkCPtPo5fcdzIvKrDxkgDTTtQhMwsixXa3xSQbEIIzSB/J8A9jm Z2RtTonofTIJBDg5g6SvjYw49CM+f8D2NGMKuRf0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Muhammad Bilal , Florian Westphal Subject: [PATCH 5.15 572/843] netfilter: nf_conntrack_irc: fix parse_dcc() off-by-one OOB read Date: Tue, 21 Jul 2026 17:23:27 +0200 Message-ID: <20260721152418.915765717@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Muhammad Bilal commit ef6400ca25a13fd6dedbe8ef4a1d0979bbbfe88a upstream. parse_dcc() treats data_end as an inclusive end pointer, but its only caller passes data_limit = ib_ptr + datalen, which points one past the last valid byte. The newline search loop iterates while tmp <= data_end, so when no newline is present, *tmp is read at tmp == data_end, one byte beyond the region filled by skb_header_pointer(). irc_buffer is kmalloc'd as MAX_SEARCH_SIZE + 1 bytes and datalen is capped at MAX_SEARCH_SIZE, so the stray read does not fault. The byte is uninitialized or stale; if it contains an ASCII digit, simple_strtoul will consume it and produce a wrong DCC IP or port in the conntrack expectation. The extra allocation byte is also a fragile guard: if the cap or allocation size changes, this becomes a real out-of-bounds read. Change the loop and its post-loop check to use strict less-than, consistent with the caller's exclusive-end convention. Update the function comment accordingly. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal Signed-off-by: Florian Westphal Signed-off-by: Greg Kroah-Hartman --- net/netfilter/nf_conntrack_irc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/net/netfilter/nf_conntrack_irc.c +++ b/net/netfilter/nf_conntrack_irc.c @@ -63,7 +63,7 @@ static const char *const dccprotos[] = { /* tries to get the ip_addr and port out of a dcc command * return value: -1 on failure, 0 on success * data pointer to first byte of DCC command data - * data_end pointer to last byte of dcc command data + * data_end one past end of data * ip returns parsed ip of dcc command * port returns parsed port of dcc command * ad_beg_p returns pointer to first byte of addr data @@ -81,10 +81,10 @@ static int parse_dcc(char *data, const c /* Make sure we have a newline character within the packet boundaries * because simple_strtoul parses until the first invalid character. */ - for (tmp = data; tmp <= data_end; tmp++) + for (tmp = data; tmp < data_end; tmp++) if (*tmp == '\n') break; - if (tmp > data_end || *tmp != '\n') + if (tmp >= data_end || *tmp != '\n') return -1; *ad_beg_p = data;