From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2270545A288; Tue, 21 Jul 2026 22:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672305; cv=none; b=eay9cQxvbbF+MrMvzunP5AATtChzokYBxci4jePY+S6g4kFVFYk58Y0XOxsqy9RszLEo8nxeoS7Un67HSHT9v+gqUn0i1DMhSt++uuQKIRfIHyFuUXhFaXfW7oxiF6dxsHPHvSPreF1V+RsbbuGpA3DTB+HGiJlXYWMosk+o388= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672305; c=relaxed/simple; bh=5FoqiNJ0B/OETYA/Mx7ZZlCccfnEfMk6qpM9eEmYn8A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rt8TNvPKxKukCLFRRWGmSi85z9hClu/a1mnmDOpIBmVnGVGxYqDEMwniVMgjiGum++BUIx9NGindCbadJXITZqqJCwAvyZB4o+ZsnZajio7B3JytAlQ2w4+ClOaEn5NU5vLVyxph/pfk3RCeGACNRUcabBHj8LMfqZChGD4+9pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=C64qO6PJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="C64qO6PJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87C471F000E9; Tue, 21 Jul 2026 22:18:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784672304; bh=eD/cUUPCkOgkut56dNTMwZv3Zhn0m7ZjF7wv3xCqalg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=C64qO6PJUprF1aup4m7OTVRybOkmjt2DEUsipSJAA3QHi68NDKupbhzrs4+J0keJE P9ojvtDNL3JM6+QZrBFgeai+8nMv4dnfno7jf9c01sG3TvRgo3Ani1AHCR1x2aQLid PkEsH0r4ZrvudJ89Gg5neMTwo6zey9rdAKa54DQY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Carlier , Florian Westphal Subject: [PATCH 5.15 573/843] netfilter: nfnl_cthelper: apply per-class values when updating policies Date: Tue, 21 Jul 2026 17:23:28 +0200 Message-ID: <20260721152418.937277203@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Carlier commit d738feccb98cb224ebabecb703e98f5008276bff upstream. When a userspace conntrack helper with multiple expectation classes is updated via nfnetlink, every class ends up with the first class's max_expected and timeout values. nfnl_cthelper_update_policy_all() validates each new policy into the corresponding slot of the temporary new_policy array, but the second loop that commits the values into the live helper dereferences new_policy as a pointer instead of indexing it, so every iteration reads new_policy[0] regardless of i. An update that changes per-class values is silently collapsed onto class 0's values with no error returned to userspace. Index the temporary array by i in the commit loop so each class gets its own validated values. Fixes: 2c422257550f ("netfilter: nfnl_cthelper: fix runtime expectation policy updates") Cc: stable@vger.kernel.org Signed-off-by: David Carlier Signed-off-by: Florian Westphal Signed-off-by: Greg Kroah-Hartman --- net/netfilter/nfnetlink_cthelper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/netfilter/nfnetlink_cthelper.c +++ b/net/netfilter/nfnetlink_cthelper.c @@ -344,8 +344,8 @@ static int nfnl_cthelper_update_policy_a for (i = 0; i < helper->expect_class_max + 1; i++) { policy = (struct nf_conntrack_expect_policy *) &helper->expect_policy[i]; - policy->max_expected = new_policy->max_expected; - policy->timeout = new_policy->timeout; + policy->max_expected = new_policy[i].max_expected; + policy->timeout = new_policy[i].timeout; } err: