From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A32E44AB6A; Tue, 21 Jul 2026 21:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784668825; cv=none; b=B+U7bC/p/Q20N6aiHG66yNyMiAuPPt9Oo3dWlhJcmDjC1AP3zvZz/YKgRT/L7sJrVM1nKQ58zQE4LoGDt1wHssapGhpPs3J/IW3b8kUj+6FSRbc7oNsdjkPVfRgJYY1hXXZCOGxS0beBqtuaw+S4JyV3by5NfzAeLY6iHZk24S8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784668825; c=relaxed/simple; bh=ei6h15TUOo6aZ+DtHeoeqN6D8gcvOdWS1zT8GLcYYFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jru4bSzeQ72fGzs1xGzktQ63W7nLoK7jkAoT8QkGPxHOjp7CLs961EXKYafi0JdFnZYvbr/Vx+ol3oJgQPH/Etv9bYg4qeTbyOCUtHObF2edKOYeF7Gal7kyqaDHgdfCyMYH0mVdtziTC2/EJJgEXlsvEkQwh9nMgYg7t6a3MSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qm6V9cIF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qm6V9cIF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B45F1F000E9; Tue, 21 Jul 2026 21:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784668824; bh=fOAb0F74lWH0tmuoYhIOTWKnutS7GSbDbuWOQob56t4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qm6V9cIF3b9gFqjJNfwdZPGZwFnMoLUWXk1l7ony32ehEEsleWzboKlW5Q8KpW3GS y8WJ5k3/a2S4gK8YJS6OnCqguwDo6XMctcJD2WfmGNehSa7+BFW12nYkXEXuZYmH3L 7fJiN5i7fY6r5sWUBzstvpmHOig64dm2QRlm1sQM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stepan Ionichev , Sasha Levin Subject: [PATCH 6.1 0321/1067] device property: fix fwnode reference leak in fwnode_graph_get_endpoint_by_id() Date: Tue, 21 Jul 2026 17:15:22 +0200 Message-ID: <20260721152431.774430165@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stepan Ionichev [ Upstream commit 9582485a65eacfd7245ec7f0a9d7e2c34749d669 ] When called with FWNODE_GRAPH_ENDPOINT_NEXT, the function walks every endpoint under the requested port and, for any endpoint whose ID is greater than or equal to the requested one, may store a fwnode reference in best_ep via fwnode_handle_get(). If a later iteration finds an exact-ID match, the function returns that endpoint directly without dropping the reference held by best_ep, leaking it. Drop the saved candidate before returning the exact-match endpoint. This affects callers that use FWNODE_GRAPH_ENDPOINT_NEXT to ask for the next endpoint with ID >= the requested one (used by a number of media drivers, e.g. imx7/8, sun6i CSI, omap3isp, xilinx-csi2, stm32-csi). Each leak retains a fwnode reference until reboot/unbind. Fixes: 0fcc2bdc8aff ("device property: Add fwnode_graph_get_endpoint_by_id()") Signed-off-by: Stepan Ionichev Link: https://patch.msgid.link/20260514171455.27271-1-sozdayvek@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/base/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/property.c b/drivers/base/property.c index 07a58e39a148fb..e41e016aa482df 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -1206,8 +1206,10 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode, if (fwnode_ep.port != port) continue; - if (fwnode_ep.id == endpoint) + if (fwnode_ep.id == endpoint) { + fwnode_handle_put(best_ep); return ep; + } if (!endpoint_next) continue; -- 2.53.0