From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9227335201C; Tue, 21 Jul 2026 21:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669322; cv=none; b=G1PqhmePTnQfAKz3Nt0VZKTVB8wkz6BDbEH5Td9GqhytYjyBooIpLtoSD7gQYvQncPKtv18qVyi1u+/pXqC6HfyQz8whe6SC1hKEu8MqbxUuAKnqB2662FpjObIvomBWF0ACwQbayy8XonQfMhCkYgjTtMEKjkwaImKzaSiSoX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669322; c=relaxed/simple; bh=D9WijTQ7rrf5Zx4jQeimj0XCBVGjYsx8g6xp39IM4rI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mDBD9o4VIJVlz/TOX2b9FXJ+vc0PD46iWwQXCC5dBI6sK1AIrgHw36jcCZoLaZ+Z8kZ180CmT8faTjcTm0lFRP6yA8xWkldkkn7Diz60anztplJDO3xnTcc/HVqPBFikmTcoSDOaroEtzeN/7PqIkl3XWZqmMmiuI1sVFXOCSJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QfU8q9y5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QfU8q9y5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C9ED1F000E9; Tue, 21 Jul 2026 21:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784669316; bh=RafJ7IhhA/6EHxmDb0/tLrdQm16llfgOr4kU/J2s3IM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QfU8q9y5WCCMaJOl7d+DiBi/TxAJpWXRPWU5pgmBQCIWs3xy3aMUgvBlTUo0ll3B8 dMFiU82bXvN3zKM9G/GZ1PEb706NFp3VMzBiIJhRLxKRH2vXYjycdaUyaXIDZgIwEd gsfRBzbmPlnxX4wV5frbY/gAEZHdVMtsu8W1mxG4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Alexandru Hossu , Sasha Levin Subject: [PATCH 6.1 0472/1067] staging: nvec: fix use-after-free in nvec_rx_completed() Date: Tue, 21 Jul 2026 17:17:53 +0200 Message-ID: <20260721152435.174873493@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexandru Hossu [ Upstream commit 26813881181deb3a32fbb59eadb2599cbe8423f6 ] In nvec_rx_completed(), when an incomplete RX transfer is detected, nvec_msg_free() is called to return the message back to the pool by clearing its 'used' atomic flag. Immediately after this, the code accesses nvec->rx->data[0] to check the message type. Since nvec_msg_free() marks the pool slot as available via atomic_set(), any concurrent or subsequent call to nvec_msg_alloc() could claim that same slot and overwrite its data[] array. Reading nvec->rx->data[0] after freeing the message is therefore a use-after-free. Fix this by saving the message type byte before calling nvec_msg_free(), then using the saved value for the battery quirk check. Fixes: d6bdcf2e1019 ("staging: nvec: Add battery quirk to ignore incomplete responses") Reviewed-by: Dan Carpenter Signed-off-by: Alexandru Hossu Link: https://patch.msgid.link/20260427081713.3401874-2-hossu.alexandru@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/nvec/nvec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index b3f114cb00dc86..46d26e3870d3de 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -489,6 +489,8 @@ static void nvec_tx_completed(struct nvec_chip *nvec) static void nvec_rx_completed(struct nvec_chip *nvec) { if (nvec->rx->pos != nvec_msg_size(nvec->rx)) { + unsigned char msg_type = nvec->rx->data[0]; + dev_err(nvec->dev, "RX incomplete: Expected %u bytes, got %u\n", (uint)nvec_msg_size(nvec->rx), (uint)nvec->rx->pos); @@ -497,7 +499,7 @@ static void nvec_rx_completed(struct nvec_chip *nvec) nvec->state = 0; /* Battery quirk - Often incomplete, and likes to crash */ - if (nvec->rx->data[0] == NVEC_BAT) + if (msg_type == NVEC_BAT) complete(&nvec->ec_transfer); return; -- 2.53.0