From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 219953BCD04; Tue, 21 Jul 2026 21:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669318; cv=none; b=uauLy1FVgM4gnhYZ4CzDi0tmlnzAapgRKZ6tBeTvQ6sN9kVkjlsNMEEhDLGDxmr4LJsHgCI41hguS5hmcOK1yBOjERgy+yN5Ofu9Lhw1x9llTluxUfdJ6ILI56DLOZww/dc4XOKLqjGzrUvsj/42e9rgo3bkHg0mkGLXJx8RshE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669318; c=relaxed/simple; bh=6lT/iVxEg6Oa2uK5Ro5V6E/prOOIsC8lgYDL8+Mh/IU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pPxTyj+k9CCVS0PU23Ld/98F5ARp+5yU7fCKo3vtrbS3dxD/k6rM1Vba1rYquejBo3eeTrotLKc9bFnYIhtASWfrgDo+EzOaQcQfsBzhhvxdIkJI1FT+cZeYV+knJmruhaqP8W2lWLbunlswMRB6KqPLo0hw9oRrhxoRiDNZ0uI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fy2GMi6K; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fy2GMi6K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA5AA1F00A3D; Tue, 21 Jul 2026 21:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784669313; bh=6n2Z9q7h+30cZTGA2c6KdmAntn86Z1MaIRDL8g2ZmOs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fy2GMi6K+6KZcjseWwCN9YsKQ5LQyg6LC5i4kLGqICTPaTEfCuG0nPFPVFWQYcroq daSsYLa7NTEdHw+eVizdGOEc/oq/VJewc1ErjM9kZ3IVurVJoZcgNegi/PZS8jG631 0HBqqlyvJNFsQB3NWBuKXxf94Gr3xgANlm6WeCl4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot , Alexey Budankov , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 6.1 0507/1067] perf mmap: Fix NULL deref in aio cleanup on alloc failure Date: Tue, 21 Jul 2026 17:18:28 +0200 Message-ID: <20260721152435.957421335@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaldo Carvalho de Melo [ Upstream commit 25627346b10e6a564610ea2c49dc6dd54812226d ] perf_mmap__aio_mmap() sets map->aio.nr_cblocks before allocating the data array. If calloc() for aiocb or cblocks fails before the data array is allocated, the return -1 path leads to perf_mmap__aio_munmap() which loops nr_cblocks times calling perf_mmap__aio_free(). Both versions of perf_mmap__aio_free() (NUMA and non-NUMA) dereference map->aio.data[idx] without checking if data is NULL, causing a NULL pointer dereference. Add NULL checks for map->aio.data at the top of both perf_mmap__aio_free() variants so the cleanup path is safe when allocation fails partway through perf_mmap__aio_mmap(). Fixes: d3d1af6f011a553a ("perf record: Enable asynchronous trace writing") Reported-by: sashiko-bot Cc: Alexey Budankov Assisted-by: Claude:claude-opus-4.6 Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/mmap.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c index 63d8a05e60544a..adc2ee6eeb8e26 100644 --- a/tools/perf/util/mmap.c +++ b/tools/perf/util/mmap.c @@ -88,10 +88,10 @@ static int perf_mmap__aio_alloc(struct mmap *map, int idx) static void perf_mmap__aio_free(struct mmap *map, int idx) { - if (map->aio.data[idx]) { - munmap(map->aio.data[idx], mmap__mmap_len(map)); - map->aio.data[idx] = NULL; - } + if (!map->aio.data || !map->aio.data[idx]) + return; + munmap(map->aio.data[idx], mmap__mmap_len(map)); + map->aio.data[idx] = NULL; } static int perf_mmap__aio_bind(struct mmap *map, int idx, struct perf_cpu cpu, int affinity) @@ -140,6 +140,8 @@ static int perf_mmap__aio_alloc(struct mmap *map, int idx) static void perf_mmap__aio_free(struct mmap *map, int idx) { + if (!map->aio.data) + return; zfree(&(map->aio.data[idx])); } -- 2.53.0