From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BCBF35C69D; Tue, 21 Jul 2026 21:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669729; cv=none; b=Wyh8UYPNwqwRrBvxDLgisXq6gP9sHihwPdUr2PtmlthlZelozmbLixZv0Nn3tZuwGd75RuaPu/PV5jC0q4AYagy1iapp/4wOH6EkxYNVs+7YQf+8ETzAO4o1hjlsm+BobzjFFs0Rek/SeksAI5LnZiFPenk2LCknL+GU8bO0oxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669729; c=relaxed/simple; bh=zJTQGMTJdJ4kqa+VM+fRAuqj1xGZy6Mqd0jar0PEX8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g72G+mkMEaQhIJ4Ye8Zno/Ad0niFkU7s0QsheHYeXiwcDLtqCdtDsM+dsgw70Z5sggk9iCMKHO6sTpCZg8TTvK7g1Y42xm9rWQqkR2FyX9Lj8vLQGr4AAahtD/G/XxZe0UF8aJ7i+Wd9ctCnHNAoIex48gsctr8REx3+8hi5Ukw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vnu2YMzh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vnu2YMzh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B84F71F000E9; Tue, 21 Jul 2026 21:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784669727; bh=7+t3KpR7BUiEto8Il7xxqwIlD5eG1yP2UMSWDrjv/J4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=vnu2YMzhkWhuSwhRFSgT1or/NPjMv41HgJNNALY053HsOh5FuM1to46OTQHBvg7At 5vMqvwcirb2D+vgXEYBm7juG2qomve+PWNNYBfr+nNimiZmS+y7SSzSJ1wT4TCAhFL ubpXHxKVlBygcSf3fSBWDRExmAKM843LR8l3F5SI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gleb Markov , Potnuri Bharat Teja , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 0665/1067] cxgb4: Fix decode strings dump for T6 adapters Date: Tue, 21 Jul 2026 17:21:06 +0200 Message-ID: <20260721152439.475037740@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gleb Markov [ Upstream commit 5d6dc22d62682d93f5f55f145ad792f2891de911 ] Depending on the value of chip_version, the correct decode set is selected. However, the subsequent matching with the t4 encoding type in the if-else block results in a reassignment, which leads to the loss of support for t6_decode as well as reinitializing of values t4_decode and t5_decode. The component history shows that the if-else block previously used for this purpose, as well as the execution order, was not affected by the change. Furthermore, it is suggested by the execution order that the scenario with overwriting and loss of support will be implemented. Delete the if-else block. Fixes: 6df397539cb0 ("cxgb4: Update correct encoding of SGE Ingress DMA States for T6 adapter") Signed-off-by: Gleb Markov Reviewed-by: Potnuri Bharat Teja Link: https://patch.msgid.link/20260629130856.1168-1-markov.gi@npc-ksb.ru Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 175bf9b1305888..1b8247bd9e9bf6 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -6737,14 +6737,6 @@ void t4_sge_decode_idma_state(struct adapter *adapter, int state) return; } - if (is_t4(adapter->params.chip)) { - sge_idma_decode = (const char **)t4_decode; - sge_idma_decode_nstates = ARRAY_SIZE(t4_decode); - } else { - sge_idma_decode = (const char **)t5_decode; - sge_idma_decode_nstates = ARRAY_SIZE(t5_decode); - } - if (state < sge_idma_decode_nstates) CH_WARN(adapter, "idma state %s\n", sge_idma_decode[state]); else -- 2.53.0