From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739E143B3F8; Tue, 21 Jul 2026 21:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669903; cv=none; b=KoPtRYVc+OtzqthbhuB64fVgk57XEBfr498hj0yVymJoOAQWoRkDHV8pg7QvEs0TJAnqYa6lxXe7NZKxgkMnVAzawmvkJ/XIljGQunuIiCSYcI8ZxRe0GttnjdbGuyrTfD+kHwrYQ8yc85jEzwLLa02UWNDU/l+P2bACF7CNrcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784669903; c=relaxed/simple; bh=DBV5Jovt/PO9w1hQoxH50b/Tm4aelfP+hvVeLi2CULk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mSmfp7Lu2KtoJubjP5cJEdWrMmQihsOolWvQwBTb5LUd13FId+g4sopDdq3GNdKndOR3RSb7lJP2ZZaW2/m4LzWwcAD8hjhP5/jRQozQ1ikBGNP/9ykkf/4eCkExicBP9T6bEQs/hO6S2D/EY3LHQBLF7WNWWCQlCGh/TMNT36E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=krQbJV64; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="krQbJV64" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FB3C1F000E9; Tue, 21 Jul 2026 21:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784669902; bh=tGvIH+bwhn8oHpw42WS3HPTQVfKGRgpUrtIipwJlo44=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=krQbJV64CtlP5Wyb5rpUu4YTM58JOe+VXVCN2qNJUBgX17LKjJ0aQ8EwiMGLafXTL y3yxsahQJPW3j7GC72Zudi7Pu8rnTOjpGeUbs905ahK/misx1H0xDxHM9kTPkNY2da RnWbwa9hnWkl8QPrPavU6WQejkuESHzXON5DEL6k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdun Nihaal , Thomas Zimmermann , Helge Deller Subject: [PATCH 6.1 0729/1067] fbdev: broadsheetfb: fix potential memory leak in broadsheetfb_probe() Date: Tue, 21 Jul 2026 17:22:10 +0200 Message-ID: <20260721152440.894892856@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdun Nihaal commit 9d18a4e4234fd3ee0d0eed8ccbbb50cb76b2232c upstream. The memory allocated for pagerefs in fb_deferred_io_init() is not freed on the error path. Fix it by calling fb_deferred_io_cleanup(). Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in pageref struct") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal Reviewed-by: Thomas Zimmermann Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/broadsheetfb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/broadsheetfb.c +++ b/drivers/video/fbdev/broadsheetfb.c @@ -1134,12 +1134,14 @@ static int broadsheetfb_probe(struct pla info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB; info->fbdefio = &broadsheetfb_defio; - fb_deferred_io_init(info); + retval = fb_deferred_io_init(info); + if (retval) + goto err_vfree; retval = fb_alloc_cmap(&info->cmap, 16, 0); if (retval < 0) { dev_err(&dev->dev, "Failed to allocate colormap\n"); - goto err_vfree; + goto err_fbdefio; } /* set cmap */ @@ -1183,6 +1185,8 @@ err_free_irq: board->cleanup(par); err_cmap: fb_dealloc_cmap(&info->cmap); +err_fbdefio: + fb_deferred_io_cleanup(info); err_vfree: vfree(videomemory); err_fb_rel: