From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0441437B02A; Tue, 21 Jul 2026 21:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670305; cv=none; b=BqbWeTo8Cgn3fx6us5bUfmt0QMpsJCPCx9tIa6HAydgGB87Je6gdJ/9V+IQQhNPT7bfHP2jQjnMCzPUUeBREh4mhU3Eo7Sx27qRHJausDPG3gH+8bVkba3HhG32X24W0UGRdPkSFG42qq9AfpXbIqghEywKSRDwuAkK3E0IB6aY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670305; c=relaxed/simple; bh=Quf/HrUNqwdLakGexbFb9SFjWD1/RsL0ak1ISETTJgs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KUYIGyhsgoCVUDmH+NrfeP9iYFJ9GQTadtBbB8gccMJvcZU6j8Qmsfq+uaeSzZVcDD0LGXsM12i1K7J2NGOIZVbXN7kDh1v+gaiRwWwb2kfG1btgQpk4ZnwAY3U8gbLHwP76DGW/Q8HZhMSgxWSrRscHwb+laqYusgbZZwcuuX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=E+wBLO6j; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="E+wBLO6j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 647A31F000E9; Tue, 21 Jul 2026 21:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784670303; bh=Yycp8J795NDtMRMMS0Is1lNFQ9wl+ebZ2I/rpvfUE7A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=E+wBLO6jx1jJSNrE4UlylaUx2G8A+hiEVJGzniUGRJdN0OkNSIaHjtBHB/7fpiVc9 dB0xUpmOPsqfVEOHJGFL+Cwvz4m+gDmNLwmT5vWbaeqr9KLX5IUIHoYKDjaW+bw4S8 bbyyJGxkFCPM0pmtPDTZcpruGP1MrUwyRP8tYsB8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiao Liang , Maoyi Xie , Kuniyuki Iwashima , Jakub Kicinski Subject: [PATCH 6.1 0880/1067] net: ip6_vti: require CAP_NET_ADMIN in the device netns for changelink Date: Tue, 21 Jul 2026 17:24:41 +0200 Message-ID: <20260721152444.216972020@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit e2ac3b242c37dff323a964962e43854f4b1a2b79 upstream. vti6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate vti6_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 61220ab34948 ("vti6: Enable namespace changing") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260612085941.3158249-7-maoyixie.tju@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv6/ip6_vti.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ipv6/ip6_vti.c +++ b/net/ipv6/ip6_vti.c @@ -1053,6 +1053,9 @@ static int vti6_changelink(struct net_de struct __ip6_tnl_parm p; struct vti6_net *ip6n; + if (!rtnl_dev_link_net_capable(dev, net)) + return -EPERM; + ip6n = net_generic(net, vti6_net_id); if (dev == ip6n->fb_tnl_dev) return -EINVAL;