From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49207413D69; Tue, 21 Jul 2026 21:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670311; cv=none; b=eQLQ/EVBz3DlRUZQHMFx83VAwWD/62Onp8+rhcc5zvVqSV+Qd2HT0j+kilQ1b52z0m4JiuJ/ly7bv86m/wY0EKrMFqdl0eY3h+IaGnGvb4XJXORhdCAVnC/O7NsJMaP+3JOwQL+qrEMTXygvqs02jTPHGQ1aUPyP8DNbx8oTc1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670311; c=relaxed/simple; bh=5LNY4pAyS2HyvNMMvpmLiTwK4PQ0W2Q8UGVzRh97cw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OB9MANY3Hu8D1LrtVv97lTLV2jMZjyNWz6CKRDvHN3f/7K3wKtbfrk0CrfxfH8KAyUxbmXhLnVVV9EjgdnAOxVyltahW9yyVeeUquzUjctnprXkVRmYrfgLdF2Mg4gZQ5fnd/kfixS0BMYs9HSCtAZVf5gqJgf3fV0iMAhpOCSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1Imy4fh2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1Imy4fh2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADDD31F000E9; Tue, 21 Jul 2026 21:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784670309; bh=yCnhhFj20XLj2JIdcQ5GwUoWV+12auwTn6QBebXgNpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1Imy4fh2xOhdtjRzFPNWjl7V1bNilOjf+nVNuk6IPv+ricSGuUNPrGlmus973IaZy BxUHrbNtGY4raLyvRd3uPn3qYiqzh2k+UQpZ9Hxq/FuTFq3q31sxvz6t1fj5+cgV6g hbLNf2mj/t15jMQzo6XyQKB7tKz9Oc5eISXCBSfM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiao Liang , Maoyi Xie , Kuniyuki Iwashima , Jakub Kicinski Subject: [PATCH 6.1 0882/1067] net: ipip: require CAP_NET_ADMIN in the device netns for changelink Date: Tue, 21 Jul 2026 17:24:43 +0200 Message-ID: <20260721152444.261249105@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152424.521567757@linuxfoundation.org> References: <20260721152424.521567757@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit 8211a26324667980a463c069469a818e71207e02 upstream. ipip_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate ipip_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 6c742e714d8c ("ipip: add x-netns support") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260612085941.3158249-3-maoyixie.tju@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv4/ipip.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@ -457,6 +457,9 @@ static int ipip_changelink(struct net_de bool collect_md; __u32 fwmark = t->fwmark; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + if (ip_tunnel_netlink_encap_parms(data, &ipencap)) { int err = ip_tunnel_encap_setup(t, &ipencap);