From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C702946D0A0; Tue, 21 Jul 2026 20:27:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665639; cv=none; b=FPHYFoul46nIqGeiyMxT9zO1lOf6Upo6L5FKkT8DYN5HPmo9rZ+30MXbLmR0jABd4UAkQFgz1fD7+BdfbYe416VZLxJR3rJNleZ+uCWPfEpLNaX+sdFCEdv1yVa+ebvfN0w1wKfZZ9RF2U0SRfeU8FCLHkDPxFCZj0yw6lWB90o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665639; c=relaxed/simple; bh=Zo9A58cbKxSXlD1dVdsMQz/h3HFxfotf2/rnaHw/F2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KT7lcG3FY8HN2tr6idJtN49+16VfiN8kc4K7XaGCMFZYUhFqM80p4e6ypczOgSMTbg12H80VwhIwpPU4mdyaRxzBhVxkxMjJ58VQp7/g3e0nfbqyYmrWH2px567+3Bjou4ZeMm96eVKAP6Db1uQohHyGoDbrjKXDQ+LhNHTeO94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TBniSQ1m; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TBniSQ1m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27C151F000E9; Tue, 21 Jul 2026 20:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784665636; bh=a7a8EOOliWGiQ6ETX/wq/uzHraBf7i3yHySjASptsJ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TBniSQ1mu1zaQtvqDK73EieI8dQ7LUBtPqTv9VyA8pvdvn7bsRFq2tyO6pgSa7SYZ k8oDCBleQrOT60Piaogs7CO/j0UeunDrct9yyLI7zjDGamjYu9bK85oSI2ofHHsqgQ WxOj0bS7scGI8YQyoIGjoUOdXuey7AUy0l+SINQE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Felix Gu , Guenter Roeck , Baolin Wang , Sasha Levin Subject: [PATCH 6.6 0380/1266] watchdog: sprd_wdt: Remove redundant sprd_wdt_disable() on register failure Date: Tue, 21 Jul 2026 17:13:37 +0200 Message-ID: <20260721152450.328869681@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Gu [ Upstream commit 96b3cfc3b8ad0524d12fed1e08bc5df3ff345f64 ] The driver uses devm_add_action_or_reset() to register sprd_wdt_disable() as a managed cleanup action. When devm_watchdog_register_device() fails, the devm core will invoke the cleanup action automatically. The explicit sprd_wdt_disable() call in the error path is therefore redundant and results in adouble cleanup. Fixes: 78d9bfad2e89 ("watchdog: sprd_wdt: Convert to use device managed functions and other improvements") Signed-off-by: Felix Gu Reviewed-by: Guenter Roeck Reviewed-by: Baolin Wang Link: https://lore.kernel.org/r/20260223-sprd_wdt-v1-1-2e71f9a76ecb@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/watchdog/sprd_wdt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/watchdog/sprd_wdt.c b/drivers/watchdog/sprd_wdt.c index 4e689b6ff1418c..aacf04616fefe2 100644 --- a/drivers/watchdog/sprd_wdt.c +++ b/drivers/watchdog/sprd_wdt.c @@ -320,10 +320,9 @@ static int sprd_wdt_probe(struct platform_device *pdev) watchdog_init_timeout(&wdt->wdd, 0, dev); ret = devm_watchdog_register_device(dev, &wdt->wdd); - if (ret) { - sprd_wdt_disable(wdt); + if (ret) return ret; - } + platform_set_drvdata(pdev, wdt); return 0; -- 2.53.0