From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A216C4302F8; Tue, 21 Jul 2026 19:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784662205; cv=none; b=VgkLWbQyndf0mLVgREDZdyUv6UOpVA6xziHQy+lrkey3/TQZs7ObWnr/x/hKFvzJBSUJra0lhGOjN8ljf1f50g+yd8QouELpWZhoFBBIXdCySaHvPVJB1uEUxxmUhUY4+eCwwHEHBOLPc0/XGdLFQsQITuAraiLaMn6ixG02vHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784662205; c=relaxed/simple; bh=8z1X/+aIvPKNHYyg6qbiSGrg/LinhWS0/PcPjBy6Egg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AEMMEooNekhfn8TbEeliauR/nznyHvFjre5UdrCi1vs60ia6b2UkLeg9I+V7uK4J0vGlDk3b+fm37vQ7W/7+5ut90ajqLFiMKvzuP1iiPLkWdoaur4ue9xanRv5OS4yFU+1yG4E1Wa6pbZ7NIFDI72Yq5R/C5g8wOxWXS2SyRDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HHg+iRAD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HHg+iRAD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B68EE1F000E9; Tue, 21 Jul 2026 19:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784662204; bh=eBx9x8xlxJgwn7W3d8/IlvdPhdyDbx+S+lc4p1jdPYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HHg+iRADH0chcZskP9gKw+PB1QNBsL+0MkiaREy9AuUKlOFkqB23dQvcpYS4FAlyu 5NLewOLhGCh02Xk8B6SG3rUYSLuzV+hLoXG6uOVA6mLl/mjTrgmT60DMdSAj4UTjzq Xmv8oGLrsTIBwCwP/nwnvhijKxZKg60nkF8OsG8I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aditya Garg , Dipayaan Roy , Haiyang Zhang , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 0355/1276] net: mana: guard TX wq object destroy with INVALID_MANA_HANDLE check Date: Tue, 21 Jul 2026 17:13:18 +0200 Message-ID: <20260721152454.056165700@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152446.065700225@linuxfoundation.org> References: <20260721152446.065700225@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aditya Garg [ Upstream commit f8fd56977eeea3d6939b1a9cd8bd36f1779b3ad0 ] mana_create_txq() has several error paths (after mana_alloc_queues() or mana_create_wq_obj() failure) where tx_qp[i].tx_object stays as the INVALID_MANA_HANDLE sentinel set at allocation. mana_destroy_txq() then unconditionally calls mana_destroy_wq_obj() with (u64)-1, which firmware rejects and logs an error. Mirror the RX-side pattern in mana_destroy_rxq() and skip the destroy when the handle is still INVALID_MANA_HANDLE. Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Signed-off-by: Aditya Garg Reviewed-by: Dipayaan Roy Reviewed-by: Haiyang Zhang Link: https://patch.msgid.link/20260608101345.2267320-3-gargaditya@linux.microsoft.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/microsoft/mana/mana_en.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index 0e4b0ac4acf86b..95c4a254953a9b 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -1865,7 +1865,8 @@ static void mana_destroy_txq(struct mana_port_context *apc) netif_napi_del(napi); apc->tx_qp[i].txq.napi_initialized = false; } - mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i].tx_object); + if (apc->tx_qp[i].tx_object != INVALID_MANA_HANDLE) + mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i].tx_object); mana_deinit_cq(apc, &apc->tx_qp[i].tx_cq); -- 2.53.0