From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CAD93B6C1E; Tue, 21 Jul 2026 20:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666293; cv=none; b=YMKZVFWTT013l+mnzDLTNC3fzTVuz1A1jLxRYVyLIoa6rV87KH6lEOxN8QvES3+/49ZrungpE9+8JH5nJm7C7nylz/YpOev3SQznzDDjDivY5Po4/EPS01zXgozqIIV+eJa+KB2OPBA8CIr79bVx50r/yDxRb91A2E4K+7qbnu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666293; c=relaxed/simple; bh=DpPDJIxI7ktBfyVCtFkT3ti/19pQZW9qUWBDJNF0Cq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iQrX134qTIvq58dWp2WAAxuWZvxAN0qLM2ddJ7Axc7/F7f+kIlttU1FW+NMVw1gByJHKt520Pet4Xku7EhDC3eRF93xn9cMxZwr8hcWTgPGSnsiWrWt1AlujGCJyjI+vhk1V/zGMbcqeXRiM5WSoBzpzCvxyCYT2VzMBRKyQ7Kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z89hdCwr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z89hdCwr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 634751F000E9; Tue, 21 Jul 2026 20:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784666287; bh=RlW2hWqvmAM3Exu7MEEkhU3gfeC6qT7qdKUno7syHmw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=z89hdCwrK9y9oz6PiYtj85qAdJw3HNZhvtMoMH5Gp45HCwg8oNe9QUqrcDEztXx0b Kz0WVACiZcUhmuMCOP6qzpP9zKrL/814HGuZ1nE9xolC9OT+vpECmx/1yV5QG6Lzr/ ZvHn2Wf09gg3KjZRTLwuHnOYxJjNS3JK8b16+WSA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Brett Creeley , Eric Joyner , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 0599/1266] ionic: Fix check in ionic_get_link_ext_stats Date: Tue, 21 Jul 2026 17:17:16 +0200 Message-ID: <20260721152455.268364577@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brett Creeley [ Upstream commit 7678e69079c10b2fb10977f28f44ddb22971ea5b ] The current check will fail if SR-IOV is not initialized for the physical function; this is because is_physfn is 0 if sriov_init() isn't run or fails. Change the check that prevents getting the link down count to use is_virtfn instead so that VFs don't get this functionality, which was the original intent. Fixes: 132b4ebfa090 ("ionic: add support for ethtool extended stat link_down_count") Signed-off-by: Brett Creeley Signed-off-by: Eric Joyner Link: https://patch.msgid.link/20260614205303.48088-2-eric.joyner@amd.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c index b07dd56b0c76d2..38c2695bc529ef 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c @@ -114,8 +114,15 @@ static void ionic_get_link_ext_stats(struct net_device *netdev, { struct ionic_lif *lif = netdev_priv(netdev); - if (lif->ionic->pdev->is_physfn) - stats->link_down_events = lif->link_down_count; + if (lif->ionic->pdev->is_virtfn) + return; + + if (!lif->ionic->idev.port_info) { + netdev_err_once(netdev, "port_info not initialized\n"); + return; + } + + stats->link_down_events = lif->link_down_count; } static int ionic_get_link_ksettings(struct net_device *netdev, -- 2.53.0