From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5761433A9FC; Tue, 21 Jul 2026 20:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666695; cv=none; b=nEMvq9X2NkorxgHh0KgpkIBShjM/HtHX6JMYrGlrfmn6aqLoF4c4p7gZpRqBjyf1HVAOQpMAYX5xZKiqp8wXmtflhDHOKn9HjFyKwSAw1FPZiLgph+llkrz1pF5M4kEYxJzhrYBCg+qPshvL0RfYOz7hrHsSDxSSc/ZJ2PMy0GI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666695; c=relaxed/simple; bh=PK1SY8+ZdQGCIW5pnniplctJYSUJlcX8xCMUbZ4h+qo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nBBFVSQanpVQqYbZ/R0vNEHOcRQFSxg3U/wtgdWZDnhNqS7rCINMg9Jzh8VLxK3XF/saLgZEfbTRQexFGD/DZpeKSKERSn/Ql22TEOPKIiCYameimaGx6N56Gj5lcVnu52i1U88ptRsZ6/M//OGgVOZmGHQB+PxzYKcj+FKih9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XeRYulzF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XeRYulzF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA2F41F000E9; Tue, 21 Jul 2026 20:44:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784666694; bh=3tZG36Ev8i1gPQmQVElD/d4aj3eIKGkTiu3rcYrnUr0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XeRYulzF+MBqEcFzz00oercNjZmfK6DlQEb0TDOd0M2112ePkD9V3TnZ7OWV6jGUG TeJHM701ZDVbtzh1iz76GfJRGFRhsHyHBIBfxW4YsidOHvaAx1c1ozhnXZtaxxJ/1H WrDnO1ADjfWcctqMUrXQs4TwksU/H9FUN/filrzM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Koichiro Den , Manivannan Sadhasivam , Bjorn Helgaas , Frank Li , Dave Jiang , Sasha Levin Subject: [PATCH 6.6 0778/1266] NTB: epf: Make db_valid_mask cover only real doorbell bits Date: Tue, 21 Jul 2026 17:20:15 +0200 Message-ID: <20260721152459.273760569@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Koichiro Den [ Upstream commit 6eb7e28f1f24a28234add38755687a7ed8bc2654 ] ndev->db_count includes an unused doorbell slot due to the legacy extra offset in the peer doorbell path. db_valid_mask must cover only the real doorbell bits and exclude the unused slot. Set db_valid_mask to BIT_ULL(db_count - 1) - 1. Fixes: 812ce2f8d14e ("NTB: Add support for EPF PCI Non-Transparent Bridge") Signed-off-by: Koichiro Den Signed-off-by: Manivannan Sadhasivam Signed-off-by: Bjorn Helgaas Reviewed-by: Frank Li Reviewed-by: Dave Jiang Link: https://patch.msgid.link/20260513024923.451765-10-den@valinux.co.jp Signed-off-by: Sasha Levin --- drivers/ntb/hw/epf/ntb_hw_epf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c index ba81311a27b430..db744750529121 100644 --- a/drivers/ntb/hw/epf/ntb_hw_epf.c +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c @@ -560,7 +560,11 @@ static int ntb_epf_init_dev(struct ntb_epf_dev *ndev) return ret; } - ndev->db_valid_mask = BIT_ULL(ndev->db_count) - 1; + /* + * ndev->db_count includes an extra skipped slot due to the legacy + * doorbell layout, hence -1. + */ + ndev->db_valid_mask = BIT_ULL(ndev->db_count - 1) - 1; ndev->mw_count = readl(ndev->ctrl_reg + NTB_EPF_MW_COUNT); ndev->spad_count = readl(ndev->ctrl_reg + NTB_EPF_SPAD_COUNT); -- 2.53.0