From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35028284662; Tue, 21 Jul 2026 19:46:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784663193; cv=none; b=EOOVA7rbIM1oh6rOHzEUL+8XZEAynKEiCdjvP29Ltb9gs90ldcpGPZTzQJsttfQ62hXBxtRkW7u9dLLulbiiSmbvNvElbwrDLju1KssrzI1Yq3xoG3AAIqcwHI10/NsqhM4WFdC9aW1c/e7X65oMb7Zl1dBMu4DqGuZkJOy6YLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784663193; c=relaxed/simple; bh=UvU4xWSXNBotXFSfuO7YyWvSdmqcrw5m5reLbMq2uSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AFVDqHrcc8FYQz97WBNdzL1HHhQ0O2XvhsBydYKxAkwZk4QfkFgrwz5EULM9yJ8WHqkLt2hg7vIc4hoWhhC9xAzp/glaj6sRqTHYAN0sKB7R5NBC10jze0/cVB6E2jYravDxAQQVGFRI2jwzNKWUMzT24hL+37xtI5x+6CFref0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zpLy0DsD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zpLy0DsD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A3B71F000E9; Tue, 21 Jul 2026 19:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784663192; bh=Zf99ivg/WiSMES6HqFyBN6X3kkxj/w1d1GV6NtQqgzM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zpLy0DsD4vRacA4kHqr7rtk17pk4xPDQOdtPhHQmMc/tLFB30HRBA7Tk1YSKYk4UK hVL18zTMKTQ0rdw72i/OjnPvGzB29vf2U65O3pijgdUpx0XbSc8JARd+QCM4yru3mS nshpuEyKf2YAenkWDdjyqPRPRj0gOEy1efRfulJY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 6.12 0693/1276] gpio: htc-egpio: use managed gpiochip registration Date: Tue, 21 Jul 2026 17:18:56 +0200 Message-ID: <20260721152501.604511676@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152446.065700225@linuxfoundation.org> References: <20260721152446.065700225@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou [ Upstream commit 17326db5f0ab4ec1901e75d052b5ebef486b467f ] egpio_probe() registers each nested gpio_chip with gpiochip_add_data() but ignores the return value. If one registration fails, probe still returns success even though one of the chips was not published to gpiolib. Use devm_gpiochip_add_data() and fail probe if any chip registration fails. This lets devres unwind already registered chips and prevents the driver from publishing a partially initialized device. Fixes: a1635b8fe59d ("[ARM] 4947/1: htc-egpio, a driver for GPIO/IRQ expanders with fixed input/output pins") Signed-off-by: Pengpeng Hou Link: https://patch.msgid.link/20260624131828.94139-1-pengpeng@iscas.ac.cn Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-htc-egpio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-htc-egpio.c b/drivers/gpio/gpio-htc-egpio.c index a40bd56673fe36..5f12ce9ac28caf 100644 --- a/drivers/gpio/gpio-htc-egpio.c +++ b/drivers/gpio/gpio-htc-egpio.c @@ -268,6 +268,7 @@ static int __init egpio_probe(struct platform_device *pdev) struct gpio_chip *chip; unsigned int irq, irq_end; int i; + int ret; /* Initialize ei data structure. */ ei = devm_kzalloc(&pdev->dev, sizeof(*ei), GFP_KERNEL); @@ -331,7 +332,10 @@ static int __init egpio_probe(struct platform_device *pdev) chip->base = pdata->chip[i].gpio_base; chip->ngpio = pdata->chip[i].num_gpios; - gpiochip_add_data(chip, &ei->chip[i]); + ret = devm_gpiochip_add_data(&pdev->dev, chip, &ei->chip[i]); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "failed to register gpiochip %d\n", i); } /* Set initial pin values */ -- 2.53.0