From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E93C53A4F4B; Tue, 21 Jul 2026 19:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784663254; cv=none; b=Q9KH1OkKrkB+VNoW66oK0pQuTwqhKzh5Ch7L+Yl/bERaG8CWerX+Hvgxa4vR8FbVPPeYat8SSja0zR2pFoDtdReS6heN11XeHmm+bmFlTdjH2s2PxtyFu39z9g0FwRXIux3afdG8GvC+8PVG6o3+cc+TOwSomkfa76XmW9LFRsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784663254; c=relaxed/simple; bh=6dGxV7RlyWD/eqRP6N1h1Bz9vBvi0zNMOtJ8D7QXEo0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=awNbBOOf6eq+Bdo5+0jfecxOkDrIXymVbma8Mppwn5K5dL2HcIOHQGcAqUw47zhuE4MJHhdiel0fRx/6La47O+wHriMS7RWwi2w1/UVIg8IXTsgq6P+XhZYSjXUOR/aU0hUwn0EOfNIKUe0fZaKtnVWmhUAqR8cc2a3d6RBUihE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jH1m0n0M; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jH1m0n0M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 555211F00A3A; Tue, 21 Jul 2026 19:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784663252; bh=DnHneWMklancTueBj76vabc8TZ9sO7SxS6CZiduSthE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jH1m0n0Mva6W93kvWdzKo3+OZSHAU0TDuHiTc1aT3IRtZn3BgGfwfldC1GWEJ+B08 QT9VMtUdQ3aoK/Sb5viju5tiHwGP8KiyiEB7AVVM4I+0DJLLtMJNxKx0b7q8bhTF5L xmsLryR51oK1TqCSHA7LGzfpwYA/FS4/ryDgvt5Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lee Jones , Jiri Kosina , Sasha Levin Subject: [PATCH 6.12 0754/1276] HID: core: Fix OOB read in hid_get_report for numbered reports Date: Tue, 21 Jul 2026 17:19:57 +0200 Message-ID: <20260721152502.951478001@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152446.065700225@linuxfoundation.org> References: <20260721152446.065700225@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lee Jones [ Upstream commit af1a9b65ebe8a948eda805c14b78d4d0767cb1b5 ] When a caller passes a size of 0 to hid_report_raw_event() for a numbered report, the function originally called hid_get_report() before performing any size validation. Inside hid_get_report(), if the report is numbered (report_enum->numbered is true), it unconditionally dereferences data[0] to extract the report ID. With a size of 0, this results in an out-of-bounds read or kernel panic. Fix this by moving the numbered report size validation check before the call to hid_get_report(), ensuring that size is at least 1 before dereferencing the data pointer. Fixes: 2c85c61d1332 ("HID: pass the buffer size to hid_report_raw_event") Signed-off-by: Lee Jones Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-core.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 87d990ada8688a..9784258e48ea29 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2010,6 +2010,13 @@ int hid_report_raw_event(struct hid_device *hid, enum hid_report_type type, u8 * u8 *cdata = data; int ret = 0; + if (report_enum->numbered && (size < 1 || bufsize < 1)) { + hid_warn_ratelimited(hid, + "Event data for numbered report is too short (%d vs %zu)\n", + size, bufsize); + return -EINVAL; + } + report = hid_get_report(report_enum, data); if (!report) return 0; -- 2.53.0