From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7B1746EC9A; Tue, 21 Jul 2026 17:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784656572; cv=none; b=dflwtpUI1pIMYWZKWQH/SQWiOcFUUDxC4B/JX6Y0j23qilgXp5LXWucl8azxUzwvd4Bdl7HziFCWWaTxm20c5Rnu2DwPKDyv+lOZHUU70oXpgI2woRHCMMLCaeW71c/+w42gO5j7F3d6rGRicrZpEVlfJtC+WhXTwRYUwxb9ZCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784656572; c=relaxed/simple; bh=qcK5u1VPU1v6W4uiznVqE9VkE2hNNTIyQ3zZZctTGD8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mADR23KVs2GBOhgHZcL8Dca5b1jG96hn+vkfY/x1v+AT9Ib4pWX1RuZW39gKrWYjbZuL0rz6Q3Scqf+1nolaRZ5R0sDiOBHdCzX09g7vwCkUE7nlnohYFqObagB3JuE9RVH4bzEL0IsKUbS48lvHWc7fqKBhZyBjCG4Iu/4/ROA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kBN6WPya; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kBN6WPya" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3117A1F000E9; Tue, 21 Jul 2026 17:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784656571; bh=PfrTJUaQ+Q3GSceHGcD/6qJ8CexrNmYeb/roAuh50wo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kBN6WPya3FQK/zD6yDIE6WaqIbD5lMbMyNR+Ptvg+gj2XkxA4AZzpj+F/UuqYZ+D5 n4fT9FFZDhh2N98bDt8j9jtXIWH6ccVYIRhY7Xv1L+P0cmkHYRmfZTwbUii0YvZ4MW kaJLcFP1V+3RIDExyRCvJBlc0XWRhbWoyYIFS+Pw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Michael S. Tsirkin" , Xie Yongji , Zhang Tianci , Jason Wang , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Sasha Levin Subject: [PATCH 6.18 0438/1611] vduse: Requeue failed read to send_list head Date: Tue, 21 Jul 2026 17:09:14 +0200 Message-ID: <20260721152525.138200088@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Tianci [ Upstream commit 373ec43ded742b2f3aecf14731ffe1a57f438f38 ] When copy_to_iter() fails in vduse_dev_read_iter(), put the message back at the head of send_list to preserve FIFO ordering and retry the oldest pending request first. Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace") Reported-by: Michael S. Tsirkin Suggested-by: Xie Yongji Signed-off-by: Zhang Tianci Reviewed-by: Xie Yongji Acked-by: Jason Wang Acked-by: Eugenio Pérez Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Message-ID: <20260226115550.1814-2-zhangtianci.1997@bytedance.com> Signed-off-by: Sasha Levin --- drivers/vdpa/vdpa_user/vduse_dev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index 458fe9b8addbc5..ecc3c5b57634bc 100644 --- a/drivers/vdpa/vdpa_user/vduse_dev.c +++ b/drivers/vdpa/vdpa_user/vduse_dev.c @@ -194,6 +194,12 @@ static void vduse_enqueue_msg(struct list_head *head, list_add_tail(&msg->list, head); } +static void vduse_enqueue_msg_head(struct list_head *head, + struct vduse_dev_msg *msg) +{ + list_add(&msg->list, head); +} + static void vduse_dev_broken(struct vduse_dev *dev) { struct vduse_dev_msg *msg, *tmp; @@ -354,7 +360,7 @@ static ssize_t vduse_dev_read_iter(struct kiocb *iocb, struct iov_iter *to) spin_lock(&dev->msg_lock); if (ret != size) { ret = -EFAULT; - vduse_enqueue_msg(&dev->send_list, msg); + vduse_enqueue_msg_head(&dev->send_list, msg); goto unlock; } vduse_enqueue_msg(&dev->recv_list, msg); -- 2.53.0