From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F38E46C4A9; Tue, 21 Jul 2026 15:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784648559; cv=none; b=chK/ijDBhKyvMtbbvhxZe7TUqIVNVPhMDo6nkdQamCJdJzL/hpynxaQN9d1CmBB2wfjD+OWDmDZHZyR2TpsxxB+6LMEVXdS1FlXrDMQPTxXQCczTRt/SGbvkSEJ0VdNhUbheYy9NnaO2+E0eajyhjBn4nPRGgD6ykXl1or/2y2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784648559; c=relaxed/simple; bh=HIQrZ3S1JPe8nIlNjnSaQ/AP8jPGyZBS1ii/UXki2Ng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c1HddPhqP30m751M+6JNpgvink82yUt2MMeiE9aw6l3uPn6/mACHOOrn5PRyjsvCJQgQ4WLiHGs5aB3ew7RJvxZpGipN5cfhHi3Z6BQvTst342aLrR/05VIQg6zHqJprtwgn7NTrQEsmDB9m3JciVvRLW7i+FWJOqsqhZm5O11c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LlWwiFbX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LlWwiFbX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A9A31F000E9; Tue, 21 Jul 2026 15:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784648558; bh=sjaurf/ZWxPzzXZu/guzJZmIz6RRQFPtbw5zOTLEUSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LlWwiFbX8gNAC1ooDIyQhXXuNM4TFL2r4q+O3Pj0pI1sn8xlXQjUexl0pscfGMeSh fIUssg7LMPkPLfxOWGyQy1/gpmf1BXmnLMg/V+oP4Ibf+Y+b5IMQkweYjddjdfzaHH ZJ4jo71JANMkDjDHe2Y49T03oFy4WocfMnTW06nU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Jose A. Perez de Azpillaga" , Dan Carpenter , Sakari Ailus , Sasha Levin Subject: [PATCH 7.1 0245/2077] staging: media: atomisp: fix loop shadowing in ia_css_stream_destroy() Date: Tue, 21 Jul 2026 16:58:38 +0200 Message-ID: <20260721152558.456864655@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jose A. Perez de Azpillaga [ Upstream commit 9087395a383212ab1beaefcbe3b57ed131c7823d ] The nested loop inside the IS_ISP2401 block incorrectly uses the same variable 'i' as the outer loop. This shadows the outer loop variable and causes premature termination or skipped array elements. Change the inner loop to use a new variable 'j' to prevent this. Fixes: 113401c67386 ("media: atomisp: sh_css: Removed #ifdef ISP2401 to make code generic") Signed-off-by: Jose A. Perez de Azpillaga Reviewed-by: Dan Carpenter Signed-off-by: Sakari Ailus Signed-off-by: Sasha Levin --- drivers/staging/media/atomisp/pci/sh_css.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c index 584751516b6969..3d1903a9880486 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -8192,7 +8192,7 @@ ia_css_stream_create(const struct ia_css_stream_config *stream_config, int ia_css_stream_destroy(struct ia_css_stream *stream) { - int i; + int i, j; int err = 0; IA_CSS_ENTER_PRIVATE("stream = %p", stream); @@ -8223,10 +8223,10 @@ ia_css_stream_destroy(struct ia_css_stream *stream) sp_pipeline_input_terminal = &sh_css_sp_group.pipe_io[sp_thread_id].input; - for (i = 0; i < IA_CSS_STREAM_MAX_ISYS_STREAM_PER_CH; i++) { + for (j = 0; j < IA_CSS_STREAM_MAX_ISYS_STREAM_PER_CH; j++) { ia_css_isys_stream_h isys_stream = - &sp_pipeline_input_terminal->context.virtual_input_system_stream[i]; - if (stream->config.isys_config[i].valid && isys_stream->valid) + &sp_pipeline_input_terminal->context.virtual_input_system_stream[j]; + if (stream->config.isys_config[j].valid && isys_stream->valid) ia_css_isys_stream_destroy(isys_stream); } } -- 2.53.0